Page 1 of 1
[RESOLVED] About the new click-and-delete feature in v2.5.1
Posted: Fri Aug 17, 2012 8:06 pm
by mjh563
Hi, I'm intrigued by this new feature in 2.5.1, but should it remove only non-static content, or any content?
+ Holding the left mouse button down on an absolutely positioned page
element and hitting the DEL key will remove it (useful to forcibly kill
in-page popups when scripts are disabled)
It currently removes the element that you click on, regardless of its position type. I think this line is incorrect (noscriptOverlay.js:2529):
Code: Select all
if (w.getComputedStyle(el, '') !== "static") {
Re: About the new click-and-delete feature in v2.5.1
Posted: Fri Aug 17, 2012 8:14 pm
by GµårÐïåñ
I have not evaluated the full code but I believe since it is removing a static content only, it should be fine. I am sure Giorgio will take a look and see.
Re: About the new click-and-delete feature in v2.5.1
Posted: Mon Aug 20, 2012 6:15 pm
by mjh563
Oh, it looks as though this has already been fixed in 2.5.2rc1.
Re: About the new click-and-delete feature in v2.5.1
Posted: Mon Aug 20, 2012 6:22 pm
by therube
Re: About the new click-and-delete feature in v2.5.1
Posted: Tue Aug 21, 2012 10:02 pm
by GµårÐïåñ
mjh563 wrote:Oh, it looks as though this has already been fixed in 2.5.2rc1.
Yes it has.