Page 1 of 1
Memory leak (not released) if Noscript menu shown
Posted: Wed Oct 19, 2011 12:31 pm
by Archaeopteryx
Firefox 7.0.1 on Windows XP SP3 32-bit
Noscript 2.1.5 and 2.1.6rc1
If the Noscript menu (the one of the button in the add-on/status bar) has been shown, there will remain some memory still associate to this page in about:memory (at least to the latest page where you have done this, but I am not sure if this can happen for multiple pages).
Steps to reproduce:
1. Create a new Firefox profile.
2. Install Noscript.
3. Open any site with Javascript, for example
http://www.procidis.com/.
4. Move the mouse above the Noscript button in the add-on/status bar, if necessary click to get the menu. (It's not necessary to change anything here.)
5. Click somewhere else to close the menu.
6. Open about:memory and close all other tabs.
7. Click 'More verbose'.
8. Click 'Minimize memory usage'.
Actual result:
There is a compartment for the page for which you opened the menu.
Expected result:
No such compartment.
Re: Memory leak (not released) if Noscript menu shown
Posted: Wed Oct 19, 2011 1:53 pm
by Giorgio Maone
As far as I can see, the compartment appears as soon as I open the page (with no need for interacting with NoScript) and goes away as soon as I close the tab + minimize memory usage, and just a bit later if I just navigate to a different page in the same page (I suppose because the content viewer sticks around for some time in order to speed up BFCache).
This doesn't look like a leak to me. Am I missing something?
Re: Memory leak (not released) if Noscript menu shown
Posted: Wed Oct 19, 2011 2:09 pm
by therube
Re: Memory leak (not released) if Noscript menu shown
Posted: Wed Oct 19, 2011 2:56 pm
by Archaeopteryx
With only about:memory open and minimizing the memory usage, the compartment for the closed tab where the Noscript menu had been shown should go away, but it persists.
I tried to reproduce the problem and discovered that only some pages seem to initialize this behaviour. Try it with
http://yfrog.com/jyeitanplanetfeedp.
Re: Memory leak (not released) if Noscript menu shown
Posted: Wed Oct 19, 2011 3:11 pm
by Giorgio Maone
OK, reproduced.
I suspect it has to do with embedding tracking, judging by the difference between the two pages mentioned in this thread.
Quite expected, the compartment goes away anyway as soon as I use the menu on a different page.
I guess I can fix it in next dev build, thanks.
Re: Memory leak (not released) if Noscript menu shown
Posted: Fri Oct 21, 2011 12:54 am
by Giorgio Maone
Re: Memory leak (not released) if Noscript menu shown
Posted: Fri Oct 21, 2011 9:58 pm
by Archaeopteryx
Verified fixed.
By the way, it would be nice if you can fix these error messages:
If you allow scripts for a site (tried (
http://www.)welt.de with temporary permission)
Error: sites.pluginSites is null
Source file: chrome://noscript/content/noscriptOverlay.js
Line: 1863
Error: this.getSites is not a function
Source file: chrome://noscript/content/noscriptOverlay.js
Line: 243
I often get both after showing the Noscript menu at
http://yfrog.com/jyeitanplanetfeedp.
Re: Memory leak (not released) if Noscript menu shown
Posted: Fri Oct 21, 2011 10:17 pm
by Giorgio Maone
Please check
latest development build 2.1.7rc1, thanks.
Re: Memory leak (not released) if Noscript menu shown
Posted: Sat Oct 22, 2011 11:53 am
by Archaeopteryx
2.1.7rc2: After clicking on an item in the menu to change a permission (again the yfrog page, switching yfrog to permanent trusted).
Error: sites.pluginSites is null
Source file: chrome://noscript/content/noscriptOverlay.js
Line: 1919
(new line number)
Re: Memory leak (not released) if Noscript menu shown
Posted: Sun Oct 23, 2011 1:50 am
by Giorgio Maone
Re: Memory leak (not released) if Noscript menu shown
Posted: Sun Oct 23, 2011 8:45 am
by Archaeopteryx
You have fixed it.