Page 1 of 1

bookmarklet handling broken, turns on scripts globally

Posted: Sat May 14, 2011 9:17 am
by Guest
bookmarklet handling is fundamentally broken in noscript
every time you run a bookmarklet, noscripts temporarily enables script globally,
but its not always temporary
for example, if the bookmarklet prompts like

Code: Select all

javascript:(function(){ prompt(location.href,location.href); })()
disabling scripts globally doesn't happen unless you close the prompt dialog by hitting ok or cancel
if you close the tab, scripts remain enabled globally until you manually forbid scripts globally

i've tested out a lame fix for this by making it impossible to enable scripts globally, see
http://forums.informaction.com/viewtopi ... 66&p=27495

Thanks

Re: bookmarklet handling broken, turns on scripts globally

Posted: Sat May 14, 2011 11:49 am
by therube
Interesting.
An unwanted side effect.
That's not good.
Dangerous you might say.
if you close the tab ...
How do you do that without dismissing the prompt?
(Suppose a Quit could do it?)

Re: bookmarklet handling broken, turns on scripts globally

Posted: Sat May 14, 2011 2:27 pm
by Guest
therube wrote:Interesting.
An unwanted side effect.
That's not good.
Dangerous you might say.
if you close the tab ...
How do you do that without dismissing the prompt?
(Suppose a Quit could do it?)
in firefox 4, javascript alerts/prompts.... no longer block the entire application (finally), only the tab, so you can close the tab without dismissing the prompt

Re: bookmarklet handling broken, turns on scripts globally

Posted: Sat May 14, 2011 3:08 pm
by therube
in firefox 4, javascript alerts/prompts.... no longer block the entire application (finally), only the tab, so you can close the tab without dismissing the prompt
Confirmed in FF4, but not for SeaMonkey 2.1!

Offhand, do you have a Bug# for that?
<RattyAway> therube: we don't have tabmodal prompts (yet)
<RattyAway> currently it 's a bit of a hack really

Re: bookmarklet handling broken, turns on scripts globally

Posted: Sat May 14, 2011 4:39 pm
by Giorgio Maone
I've got a pretty clear idea of what's going on. Will be fixed in next dev build.

Re: bookmarklet handling broken, turns on scripts globally

Posted: Sat May 14, 2011 8:31 pm
by Giorgio Maone
Fixed in latest development build, thanks.