Page 1 of 1

[FIXED] NoScript toolbar changes break "small icons" mode.

Posted: Mon Jan 24, 2011 7:45 am
by che
Image
This is what my NoScript toolbar button looks like in v2.0.9.6, when "icon only" and "small icons" toolbar mode is set. Note that NoScript icon is higher than everything else on the toolbar, making screen space used by the toolbar the same as if "small icons" mode was off.

Would it be possible to revert to behavior of previous versions (I had something like v2.0.9.3 before upgrading), that had the arrow next to the icon and made everything fit to the toolbar, at least in "small icons" mode, please?

Re: NoScript toolbar changes break "small icon only" mode.

Posted: Mon Jan 24, 2011 7:49 am
by Giorgio Maone
  1. In default configuration (NoScript Options|General|Open permissions menu when mouse hovers over NoScript's icon) you shouldn't have any arrow at all
  2. Even if you uncheck that option, the arrow should still sits on the right of the icon
However I've seen this reported by other people (mostly on Linux).
Are you using any non-default theme?

Re: NoScript toolbar changes break "small icon only" mode.

Posted: Mon Jan 24, 2011 2:56 pm
by Mc
Since dropmarkers are mostly useless, you could try erasing it to get a good looking button. This code in userChrome.css should do it:

Code: Select all

#noscript-tbb .toolbarbutton-menubutton-dropmarker,
	#noscript-tbb .toolbarbutton-menu-dropmarker,
	{ display: none !important; }
You need both, because there are two different dropmarkers, depending from your NoScript settings.

Re: NoScript toolbar changes break "small icon only" mode.

Posted: Mon Jan 24, 2011 3:04 pm
by Mc
Correction, there is a comma left from my other code

Code: Select all

#noscript-tbb .toolbarbutton-menubutton-dropmarker,
   #noscript-tbb .toolbarbutton-menu-dropmarker
   { display: none !important; }

Re: NoScript toolbar changes break "small icon only" mode.

Posted: Mon Jan 24, 2011 9:50 pm
by parliament
This fixed my problem in Windows, thanks.

(I don't use small icons, but it still caused a problem for me with the "Firefox 2, the theme, reloaded" theme.)

Re: NoScript toolbar changes break "small icon only" mode.

Posted: Tue Jan 25, 2011 8:40 am
by Guest
A strange thing here:
I had the same problem (the arrow below the button causing an increase of the toolbar height).
I had (NoScript Options|General|Open permissions menu when mouse hovers over NoScript's icon) unchecked.
I checked it : the arrow disappeared and the toolbar height decreased.
I unchecked it again : the arrow reappeared but on the right of the button (causing no change in the toolbar height)

Re: NoScript toolbar changes break "small icon only" mode.

Posted: Tue Jan 25, 2011 9:47 am
by Mc
So you've seen the mystery of the two buttons.
You get different arrows, depending whether "Left clicking..." is checked or not, when hovering is toggled, one with button type="menu-button" and the other type="menu". With some themes the arrow is never below the button, but near or with a gap aside.

Re: NoScript toolbar changes break "small icon only" mode.

Posted: Tue Jan 25, 2011 11:24 am
by Giorgio Maone
Could you check latest development build?
It should have a work-around (blind, as I couldn't reproduce yet).

Re: NoScript toolbar changes break "small icon only" mode.

Posted: Tue Jan 25, 2011 1:08 pm
by che
I'm using Firefox/3.6.13 on Linux with the default theme. 2.0.9.7rc2 development build does not help. Checking "Open permissions menu when mouse hovers over NoScript's icon" kills the arrow, as does CSS change suggested by Mc.

Re: NoScript toolbar changes break "small icon only" mode.

Posted: Tue Jan 25, 2011 2:30 pm
by Mc
Giorgio Maone wrote:Could you check latest development build?
It should have a work-around (blind, as I couldn't reproduce yet).
Now toggling "Left clicking..." setting changes the buttons/arrows at once, so the function of button and arrow type="menu-button" is more obvious. I think it's no good idea to erase this arrow with code "#noscript-tbb .toolbarbutton-menubutton-dropmarker" if it's function is wanted (left click on the arrow to get the menu without toggling permissions).

Re: NoScript toolbar changes break "small icon only" mode.

Posted: Tue Jan 25, 2011 9:44 pm
by Giorgio Maone
Please recheck latest development build (2.0.9.7rc3)

Re: NoScript toolbar changes break "small icon only" mode.

Posted: Tue Jan 25, 2011 10:27 pm
by Mc
Giorgio Maone wrote:Please recheck latest development build (2.0.9.7rc3)
Fixed now in Fx4.0b9.

Re: NoScript toolbar changes break "small icon only" mode.

Posted: Thu Jan 27, 2011 1:39 am
by che
Giorgio Maone wrote:Please recheck latest development build (2.0.9.7rc3)
Also fixed in Firefox/3.6.13. Thank you very much!