Page 1 of 1

[FIXED] wrong icon: scriptless page with blocked embeddings

Posted: Tue Jun 15, 2010 12:05 am
by al_9x
fx 3.6.3 ns 1.9.9.90, new profile, forbid iframes, apply to trusted

A page with no scripts and a blocked iframe has the following icons

1) when allowed: Image
2) when not allowed: Image

the S should be white to indicate scriptlessness, definitely in the first case
in the second, I am not sure, perhaps make the S white and slap a small puzzle in the bottom right. That would accurately communicate three pieces of information: no scripts, not whitelisted, blocked embeddings

Re: wrong icon: scriptless page with blocked embeddings

Posted: Tue Jun 22, 2010 2:15 pm
by Giorgio Maone

Re: wrong icon: scriptless page with blocked embeddings

Posted: Tue Jun 22, 2010 6:42 pm
by al_9x
fixed

Re: wrong icon: scriptless page with blocked embeddings

Posted: Wed Jun 23, 2010 4:36 am
by al_9x
a couple variations
  1. page has inline script, is not allowed, has blocked embedding with a trusted domain, forbid iframes, "apply to whitelisted" not set

    Code: Select all

    <iframe src="http://www.google.com"></iframe>
    <script></script>
    
    1. embedding is blocked even though its domain is whitelisted, I take it that's expected, since the parent is not whitelisted?
    2. but the icon is as if the embedding is loaded Image, so either the behavior or the icon is wrong, if the icon, then it should probably be: Image
    3. if the blocking behavior is correct, it might make sense to keep the embedding domain out of the root NS menu, same as in the "apply to whitelisted" case, since its whitelist state makes no difference.
  2. same as #1, without the script

    Code: Select all

    <iframe src="http://www.google.com"></iframe>
    1. icon is: Image should probably be: Image
    2. see 1.3, is it possible that doing this for both cases will also have the effect of fixing the icon?

Re: wrong icon: scriptless page with blocked embeddings

Posted: Wed Jun 23, 2010 10:05 am
by Giorgio Maone
al_9x wrote:a couple variations
These seem fixed to me in latest development build (as a side effect of some other change, though, since I didn't focus on them until now).

Re: wrong icon: scriptless page with blocked embeddings

Posted: Wed Jun 23, 2010 11:16 am
by al_9x
Giorgio Maone wrote:
al_9x wrote:a couple variations
These seem fixed to me in latest development build (as a side effect of some other change, though, since I didn't focus on them until now).
No, still in 1.9.9.95rc3