Page 1 of 1

[RESOLVED] BUG: Meta Refresh Redirect Not Caught?

Posted: Fri Oct 09, 2009 10:18 pm
by Gliktch
Firstly, I want to say thanks for your great work, I'm an avid user of both NoScript and FlashGot :D

Now, to the problem at hand... On the website http://www.seeitworks.com and at least one other site that I encountered today (sorry, didn't note the address of the other one), I am being redirected once the page has finished loading, due to this code in the page:

<noscript><meta http-equiv='REFRESH' content='0;URL=javascript.php'></noscript>

I have meta redirects disabled in NoScript's options, and I have tried updating to the development build (1.9.9.09), but still getting the same behaviour. I also tried clearing cookies as mentioned in another thread on a similar issue but that didn't help. I've already got what I want from that website and so don't need any specific help with it (just giving the ESC key a workout at the right moment was enough lol), but I wanted to be sure and post the info so I can know that I may have helped make this awesome add-on just a tiny bit better. :)

I'm sure this won't be a hard one for you to tackle ;)

Cheers,
- Matthew

Re: BUG: Meta Refresh Redirect Not Caught?

Posted: Fri Oct 09, 2009 11:34 pm
by Tom T.
I got the proper "blocked redirect" message going there without any scripts allowed. When I temp allowed the home page, the block message disappeared, and there was a placeholder for Flash object from files.bannersnack.net etc., but still no redirect. To where are you being redirected?

Are you allowing other objects, such as the above, in addition to the site's own scripting? Try with nothing allowed.

This test was with old Fx 2.20. Will attempt to reproduce with F3.5.3.

Cheers,
- Tom

Re: BUG: Meta Refresh Redirect Not Caught?

Posted: Fri Oct 09, 2009 11:52 pm
by Tom T.
I can't reproduce this on F3.5.3, even with the *entire page* temp allowed. Still get the proper bar at the top, "NoScript blocked a <META> redirection inside a <NOSCRIPT> element: javascript.php in 0 seconds".

Do you have META redirect blocked in *both* places in NS? On the Notifications tab *and* on Advanced > Untrusted tab?

Re: BUG: Meta Refresh Redirect Not Caught?

Posted: Sat Oct 10, 2009 1:46 am
by Gliktch
False alarm guys, I had the box under Notifications ticked but must have unticked the one under Advanced>>Untrusted at some point (maybe a couple of months ago, just never been affected negatively till now).

Is the first one just for enabling disabling the message itself, it doesn't change any actual behaviour of the mod? It might be a good idea to change the text on the first box to make it clearer - right now BOTH tickboxes have the exact same description; "Forbid META redirections inside <NOSCRIPT> elements". If the first one had said something like "Show message about blocked META redirections", then I would have known to keep looking and find the second box ;)

Thanks again for your fine add-on,
- Matthew

Re: BUG: Meta Refresh Redirect Not Caught?

Posted: Sat Oct 10, 2009 2:53 am
by Tom T.
Gliktch wrote:... It might be a good idea to change the text on the first box to make it clearer - right now BOTH tickboxes have the exact same description; "Forbid META redirections inside <NOSCRIPT> elements". If the first one had said something like "Show message about blocked META redirections", then I would have known to keep looking and find the second box ;)
That's an excellent suggestion. I can understand the confusion. I'll pass it along to NoScript Developer Giorgio Maone.
In the meantime, glad we got that fixed, and I'll mark the topic as resolved.

Thanks very much for the kind words. They mean a lot.
-- Tom