NoScript 11.4rc3 - "NoScript Options" Theme (since 11.4rc1?)

Bug reports and enhancement requests
Post Reply
DJ-Leith
Senior Member
Posts: 149
Joined: Thu Aug 04, 2011 4:23 pm

NoScript 11.4rc3 - "NoScript Options" Theme (since 11.4rc1?)

Post by DJ-Leith »

Using Firefox ESR, on Windows 7.

Conventions:
I am using single quotes (') for slang / imprecise language and
double quotes (" ") for direct quotations of text that I can see.


I Updated a Profile from 11.3.8rc6 to 11.4rc3.

In 11.3.8rc6 all was OK.


In 11.4rc3, I have noticed the following:

In the "NoScript Options", General 'Tab' there is 'nothing to see' for
"Default", "Trusted" or "Untrusted". Even the 'Tab Titles' are not shown.

As there is 'nothing to see', there is 'nothing to tick'.

For example, I would expect to be able to go to the "Trusted" 'Tab'
and be able to 'tick' "LAN" or "webgl" if I wanted to allow these (or 'untick' them).

As I 'can't see anything' I don't know the 'status' of any of the choices.


The Profile that I Updated should have:
"Any capability blocked in the top document must be blocked in its subdocuments too"
'ticked'.

The 'text' is visible, as is the 'box to tick' but I can't 'tick this box'.
Trying to 'tick' this option has no effect in the UI.
It looks like it is 'unticked'. It looks like I have 'lost this setting'.

Another thing I have noticed is in the "NoScript Options", Advanced 'Tab':

"Revoke temporary permissions on NoScript updates, even if the browser is not restarted"

I would expect, on the Profile I updated, for this to be 'ticked'.
Again, it is 'showing as unticked' (so I appear to have 'lost this choice')
and I can't 'tick' it (to set it back).

In the "NoScript Options", Appearance 'Tab' there is a 'new section' called "Theme".
I again 'can't tick' any of the 'boxes' but I can select the 'round radio choice'
for e.g. "Dark". However, although the 'choice is shown as chosen' no change takes place.
Each time I return to look at the "NoScript Options", Appearance 'Tab' I have
'reverted to' the "Auto" choice.


There are other 'things I can't see' / 'things I can't tick'.


I see from Getit
https://noscript.net/getit
v 11.4rc1
============================================================
x Dark/Light/Auto theme switcher in Appearance options panel
x Ensure better visibility for in-popup message box
that the "theme switcher" is new in 11.4rc1.

As a test, I 'cloned a Profile' that was at 11.3.8rc6 and Updated it to 11.4rc1.

I wanted to check if 'my settings', that I have on each 'real Profile',
would 'survive the NoScript Update' (even if they appear to 'have changes' – as shown in the UI).

As part of this test I 'Temp Allowed' two sites, in two Tabs, to see if the option:
"Revoke temporary permissions on NoScript updates, even if the browser is not restarted"
was 'still working as I Updated NoScript'.

In the 'Test Profile':
The "NoScript Options", General 'Tab' has for "Default" only "noscript" and "other" 'ticked'.
The "NoScript Options", General 'Tab' has for "Trusted" includes "font" (as one of the 'ticked options').

So, when I Update NoScript I expect to "Revoke temporary permissions ..."
and so, see the 'font change' at the websites that I had 'Temp Allowed'.

Good News, it seems as if the "Revoke temporary permissions ..." was 'still working'.
I saw the 'font change'.

I closed Firefox, then started it again using the 'Test Profile' which was now at 11.4rc1.

I can confirm that 11.4rc1 has all of the above issues.

So it seems that on my 'old Windows 7 PC', using Firefox 91.7.0esr, the new "theme switcher"
is making NoScript 'difficult to use' with any confidence. It is possible that 'all my choices' are
still as I had them (in the past) but they now 'look as if they have changed'.


DJ-Leith
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0
User avatar
Giorgio Maone
Site Admin
Posts: 9454
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: NoScript 11.4rc3 - "NoScript Options" Theme (since 11.4rc1?)

Post by Giorgio Maone »

Could you please send me some screenshots?
Thanks!
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:98.0) Gecko/20100101 Firefox/98.0
DJ-Leith
Senior Member
Posts: 149
Joined: Thu Aug 04, 2011 4:23 pm

Re: NoScript 11.4rc3 - "NoScript Options" Theme (since 11.4rc1?)

Post by DJ-Leith »

I have sent Giorgio an e-mail with a PDF which has 17 screenshots with captions. All the screenshots and the text can be put in the public domain. I initially made these screenshots and captions so that I could 'add them to the thread'.

I don't have an account with an image sharing service, so I can't make links to them in the thread at the forum.

To do this documentation I started with a clone of 'Test Profile'. All my Profiles have NoScript and uMatrix. For the screenshots I only did a 'direct Update' from 11.3.8rc6 to 11.4rc1. So, this time I did not do some of the things I mentioned in the 'first post' of the thread.

As always, I am very grateful for all Giorgio does.

DJ-Leith
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0
User avatar
Giorgio Maone
Site Admin
Posts: 9454
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: NoScript 11.4rc3 - "NoScript Options" Theme (since 11.4rc1?)

Post by Giorgio Maone »

Got your screenshots, thank you very much.
Let me guess: you've got dom.storage.enabled set to false in your test profile(s), right?
That's the issue: it breaks theme preference persistence, which needs to be synchronous in order to avoid visual flashing.
Fixing this in next RC, but I'm not sure whether this means I've got to disable explicit theme switching for users who force this setting.
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:98.0) Gecko/20100101 Firefox/98.0
DJ-Leith
Senior Member
Posts: 149
Joined: Thu Aug 04, 2011 4:23 pm

Re: NoScript 11.4rc3 - "NoScript Options" Theme (since 11.4rc1?)

Post by DJ-Leith »

Giorgio Maone wrote: Wed Mar 16, 2022 4:48 pm Let me guess: you've got dom.storage.enabled set to false in your test profile(s), right?
Yes, all my Profiles (including the clones I used for testing) have dom.storage.enabled set to false.

DJ-Leith
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0
User avatar
Giorgio Maone
Site Admin
Posts: 9454
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: NoScript 11.4rc3 - "NoScript Options" Theme (since 11.4rc1?)

Post by Giorgio Maone »

DJ-Leith wrote: Wed Mar 16, 2022 5:08 pm Yes, all my Profiles (including the clones I used for testing) have dom.storage.enabled set to false.
Please check latest development build:

v 11.4rc5
============================================================
x Fix breakage when dom.storage.enabled is set to false
(thanks DJ-Leith for report)

x [l10n] Many languages updates
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:99.0) Gecko/20100101 Firefox/99.0
DJ-Leith
Senior Member
Posts: 149
Joined: Thu Aug 04, 2011 4:23 pm

Re: NoScript 11.4rc3 - "NoScript Options" Theme (since 11.4rc1?)

Post by DJ-Leith »

Thanks for this.

Tests done:
I have done a 'normal Update', using "about:addons", to get the 'latest' NoScript (on the Dev/Beta channel) on two 'Test Profiles'.

From 11.4rc1 to 11.4rc5 <== this was the 'busted Test Profile' that I documented in the 17 screenshots.
From 11.3.8rc6 to 11.4rc5 <== this was on a clone of one of my 'real Profiles'.

Both Profiles 'kept their NoScript settings', as one would expect.

I have had a 'play with changing the Appearance' and 11.4rc5 seems to be working well. :D


DJ-Leith
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0
Post Reply