Page 1 of 1

Bug in 10.1.9.1 with local disk pages

Posted: Sat Sep 01, 2018 12:47 am
by Kevin 4368
Hi,

I upgraded NoScript to 10.1.9.1 and started getting a problem in Firefox 61.0.2 with web pages on the local disk. It didn't happen in previous versions and I tried disabling it and it fixed the problem, so the bug was introduced in this latest version. The web pages from the local disk show the content of <noscript> elements even though Javascript runs correctly. I think I enabled the domain for local hard drive web pages in a previous version of NoScript years ago, although the latest interface does not seem to show that as an option. However, it should retain the previous settings and it certainly should not show the <noiscript> content when Javascript is running.

Thanks.

Re: Bug in 10.1.9.1 with local disk pages

Posted: Sat Sep 01, 2018 1:08 am
by barbaz
Confirmed. Test page -

Code: Select all

<!doctype html>
<div id="1">JS didnt run (yet?)</div>
<script>document.getElementById('1').textContent = 'JS ran';</script>
<noscript>JS is Not Enabled!!!!!!</noscript>

Re: Bug in 10.1.9.1 with local disk pages

Posted: Tue Sep 04, 2018 7:12 am
by eski
I think I've got this problem too! My local disk pages have started acting strangely and it only goes away when I disable NoScript...

Re: Bug in 10.1.9.1 with local disk pages

Posted: Tue Sep 04, 2018 4:15 pm
by Giorgio Maone
Please check whether the problem persist with latest development build, thanks.

Re: Bug in 10.1.9.1 with local disk pages

Posted: Tue Sep 04, 2018 5:56 pm
by barbaz
10.1.9.2rc1 is better, but not completely fixed. It looks like there maybe a race condition that can still produce this bug. I can reproduce it starting from a clean profile, if I perform the following steps quickly enough -

1) install NoScript 10.1.9.2rc1 from https://noscript.net/getit#devel

2) drag the local file test page into the tab bar so that it opens as a new tab, and click its tab

Reloading the local test page gets it working.

Re: Bug in 10.1.9.1 with local disk pages

Posted: Wed Sep 05, 2018 6:05 am
by skriptimaahinen
Happens on rc2 too. Simply using Open File is enough, but happens only once per session. Even opening another file on a new tab does not reproduce the problem.

This is the only error in the console I think might be related:

ReferenceError: ns is not defined

--

Unrelated to this issue as far as I can tell, but too lazy to make a new thread :)

Code: Select all

RequestGuard.js:43
                                             v------------v
let requestKey = Policy.requestKey(url, documentUrl, policyType);

Re: Bug in 10.1.9.1 with local disk pages

Posted: Mon Sep 10, 2018 6:09 pm
by Thomas D
10.1.9.5 fixed it for me, thanks!

Re: Bug in 10.1.9.1 with local disk pages

Posted: Mon Sep 10, 2018 6:32 pm
by barbaz
10.1.9.6rc2 LGTM Image