Page 1 of 1
Bring back shift-click on script for NS10?
Posted: Sun Feb 18, 2018 4:48 pm
by kukla
Unaware if this has been discussed already, but any plans to bring back the shift-click feature to see what VirusTotal etc. report for a specific script? Or is this now available by way of something other than shift-click? Very useful feature. Would love to see it restored.
Re: Bring back shift-click on script for NS10?
Posted: Sun Feb 18, 2018 5:17 pm
by barbaz
It's available by middle-click on the site name, but last i checked the site it takes you to is hard-coded.
Re: Bring back shift-click on script for NS10?
Posted: Sun Feb 18, 2018 9:53 pm
by kukla
barbaz wrote:It's available by middle-click on the site name, but last i checked the site it takes you to is hard-coded.
No middle click on Mac. But this is what I get with left click. After hitting OK, nothing happens.
Re: Bring back shift-click on script for NS10?
Posted: Sun Feb 18, 2018 10:11 pm
by barbaz
Sorry, I got a bit mixed up. You're right, it's left-click, not middle-click.
kukla wrote: this is what I get with left click. After hitting OK, nothing happens.
I think this is a bug. Possibly related console messages -
(on clicking the site)
Code: Select all
Discarding onCreatedNavigationTarget for 95: received source tab data without any created tab data available
(on clicking OK)
Code: Select all
TypeError: can't access dead object[Learn More] Storage.js:14:5
Re: Bring back shift-click on script for NS10?
Posted: Thu Feb 22, 2018 2:44 pm
by kukla
Giorgio?
Re: Bring back shift-click on script for NS10?
Posted: Tue Feb 27, 2018 3:17 pm
by kukla
Don't understand the silence. This is an almost indispensable feature (very tedious, next to impossible, to copy the urls of many scripts and then enter them, one by one, into VirusTotal.) I understand if it takes some time to investigate and hopefully fix. But please at least some response. Thanks.
Re: Bring back shift-click on script for NS10?
Posted: Tue Feb 27, 2018 8:45 pm
by Giorgio Maone
kukla wrote:Don't understand the silence. This is an almost indispensable feature (very tedious, next to impossible, to copy the urls of many scripts and then enter them, one by one, into VirusTotal.) I understand if it takes some time to investigate and hopefully fix. But please at least some response. Thanks.
I cannot reproduce the bug.
Firefox 58.0.2, clean
profile. Installed NoScript, left clicked the first address listed either in the popup or in the Options page (tried both, in different profiles since your choice after the privacy warning prompt is remembered), and both times the noscript.net/about page has been correctly opened.
Might this be platform specific (barbaz, did you try on Mac OS X as well)?
I tried on Linux and Windows, BTW, no mac at hand ATM.
Re: Bring back shift-click on script for NS10?
Posted: Tue Feb 27, 2018 11:39 pm
by barbaz
Giorgio Maone wrote:(barbaz, did you try on Mac OS X as well)?
I don't have Mac OS for some years now. I use Xubuntu 16.04 64-bit.
The only possibly-relevant environment details I can think of are:
1) I use the Firefox 58.0.2 add-on-devel unbranded build
2) I always run Firefox in a firejail sandbox -
Code: Select all
firejail --overlay-tmpfs --noprofile firefox/firefox
STR:
1)
https://noscript.net/getit, install NoScript Quantum latest dev build
2) open the NoScript popup
3) left-click "noscript.net"
Re: Bring back shift-click on script for NS10?
Posted: Wed Feb 28, 2018 11:59 am
by Giorgio Maone
barbaz wrote:Giorgio Maone wrote:(barbaz, did you try on Mac OS X as well)?
I don't have Mac OS for some years now. I use Xubuntu 16.04 64-bit.
Confirmed, it's platform-dependent (most likely window manager specific).
The problem happens only when you use this feature
for the first time from the popup (instead of the Options tab), because on some (non-Windows) platforms the confirmation prompt causes the popup to be dismissed along with all its running code, therefore once you answer there's no code still alive to act on your input.
I'll probably have to fix it by temporarily opening the NoScript Options tab, handling the confirmation prompt from there, then closing it and either go back to the original tab or opening the information page, depending on user's answer.
Work around: just use this feature once from the Options page, giving NoScript permission to permanently enable it.
Re: Bring back shift-click on script for NS10?
Posted: Wed Feb 28, 2018 2:57 pm
by kukla
Thanks Giorgio for the workaround, which works perfectly. Was concerned it wouldn't last through a restart (browser), but it does. Very good to have this feature working again.