docShellJSBlocking obsolete ?

Ask for help about NoScript, no registration needed to post
Vidad

docShellJSBlocking obsolete ?

Post by Vidad »

Vidad wrote: 2 - docShell JS blocking for every non-whitelisted site (enables
cross-frame inheritance of JS blocking)

I had it set to 2. Why has it become obsolete ? I suppose it's due to content being run in a separate process with e10s, but could you guys provide some more technically detailed reasons ?
"docShell JS blocking" (i.e. setting docShell.allowJavascript to false) been redundant since NoScript has not been using CAPS anymore to enforce script permissions, because the "new" way (setting a flag at the window level) was inherited by sub-documents by default.
I've removed this option completely now because with e10s this is a source of annoying bugs, too.
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0
User avatar
Thrawn
Master Bug Buster
Posts: 3106
Joined: Mon Jan 16, 2012 3:46 am
Location: Australia
Contact:

Re: docShellJSBlocking obsolete ?

Post by Thrawn »

Vidad wrote: NoScript has not been using CAPS anymore to enforce script permissions
Is that true for all supported browsers?
======
Thrawn
------------
Religion is not the opium of the masses. Daily life is the opium of the masses.

True religion, which dares to acknowledge death and challenge the way we live, is an attempt to wake up.
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0
User avatar
Giorgio Maone
Site Admin
Posts: 9526
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: docShellJSBlocking obsolete ?

Post by Giorgio Maone »

Thrawn wrote:
Vidad wrote: NoScript has not been using CAPS anymore to enforce script permissions
Is that true for all supported browsers?
CAPS is completely gone since Gecko 31 at least.
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:50.0) Gecko/20100101 Firefox/50.0
barbaz
Senior Member
Posts: 11089
Joined: Sat Aug 03, 2013 5:45 pm

Re: docShellJSBlocking obsolete ?

Post by barbaz »

Vidad wrote:"docShell JS blocking" (i.e. setting docShell.allowJavascript to false) been redundant since NoScript has not been using CAPS anymore to enforce script permissions, because the "new" way (setting a flag at the window level) was inherited by sub-documents by default.
I've removed this option completely now because with e10s this is a source of annoying bugs, too.
Not sure what happened to this thread, but this part of the OP looks like it was written by Giorgio. Is that the case?
*Always* check the changelogs BEFORE updating that important software!
-
User avatar
Giorgio Maone
Site Admin
Posts: 9526
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: docShellJSBlocking obsolete ?

Post by Giorgio Maone »

barbaz wrote:
Vidad wrote:"docShell JS blocking" (i.e. setting docShell.allowJavascript to false) been redundant since NoScript has not been using CAPS anymore to enforce script permissions, because the "new" way (setting a flag at the window level) was inherited by sub-documents by default.
I've removed this option completely now because with e10s this is a source of annoying bugs, too.
Not sure what happened to this thread, but this part of the OP looks like it was written by Giorgio. Is that the case?
Yes, I did edit by error instead of replying w/ quote, sorry :(
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:50.0) Gecko/20100101 Firefox/50.0
Vidad

Re: docShellJSBlocking obsolete ?

Post by Vidad »

Thanks for the reply!
the "new" way (setting a flag at the window level) was inherited by sub-documents by default.
So if I get it right, not only is the docShellJSBlocking pref redundant, but the "new" way actually behaves the same as if docShellJSBlocking was set to 2 ?

Sounds nice. So now I wonder why docShellJSBlocking's default was 1, but I guess that doesn't matter in any half-recent version of Firefox.
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0
barbaz
Senior Member
Posts: 11089
Joined: Sat Aug 03, 2013 5:45 pm

Re: docShellJSBlocking obsolete ?

Post by barbaz »

Vidad, if I'm understanding correctly, you're actually looking for about:config > noscript.restrictSubdocScripting
*Always* check the changelogs BEFORE updating that important software!
-
Vidad

Re: docShellJSBlocking obsolete ?

Post by Vidad »

Yes, sounds like this is it, and I do restrict sub-document scripting already.

Reposting the details for the removed pref:
+ New values for the noscript.docShellJSBlocking preference:
0 - no docShell JS blocking
1 - (default) docShell JS blocking for untrusted sites (enables
effective blacklists for defalut-deny modes)
2 - docShell JS blocking for every non-whitelisted site (enables
cross-frame inheritance of JS blocking)

Sounds like the following is correct when sub-doc scripting is restricted, right ?
So if I get it right, not only is the docShellJSBlocking pref redundant, but the "new" way actually behaves the same as if docShellJSBlocking was set to 2 ?

Either way, thanks guys for your explanations!
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0
Post Reply