Page 1 of 1

noscript.forbidIFrames not working with ABE enabled

Posted: Wed Jul 29, 2009 3:01 pm
by Mike A.
Reporting possible bug regarding the Forbid IFRAME option (NoScript Options|Plugins|Forbid IFRAMEs) with Firefox 3.5.1 and NoScript 1.9.7. Possibly related to the Fx2 post 1.9.5 iframe regression topic.

noscript.forbidFrames;true
noscript.forbidIFrames;true
noscript.forbidIFramesContext;0

No domains in whitelist and ABE enabled with default rules.

Click an image on http://images.google.com and an iframe is used to display the page containing the image.

The first time an image is clicked the iframe loads and the second time the iframe is blocked by NoScript. With ABE disabled the iframe is blocked by NoScript the first time an image is clicked.

Edit to clarify the *same* image is clicked the second time when NoScript blocks the iframe.

Re: noscript.forbidIFrames not working with ABE enabled

Posted: Wed Jul 29, 2009 4:24 pm
by therube
I'm not following how to duplicate this?
Could you go through the steps again.

In particular I'm missing how you are clicking the same image the second time?
Are you opening the image in the same window, or a new tab?

Do you have, Apply these restrictinos to trusted sites too enabled?

Re: noscript.forbidIFrames not working with ABE enabled

Posted: Wed Jul 29, 2009 4:42 pm
by Giorgio Maone
It appears to come from the magic we must do in order to keep DNS queries asynchronous and nevertheless let ABE block stuff reliably.
It will be fixed in next dev build, thanks for reporting.

Re: noscript.forbidIFrames not working with ABE enabled

Posted: Wed Jul 29, 2009 5:11 pm
by Mike A.
therube wrote:In particular I'm missing how you are clicking the same image the second time?
Are you opening the image in the same window, or a new tab?
Ctrl-Click an image to open the page in a new tab, then close the tab and Ctrl-Click the same image again.
-OR-
Click an image to open the page in the same tab, then use the back button and Click the same image again.
therube wrote:Do you have, Apply these restrictinos to trusted sites too enabled?
No.

Re: noscript.forbidIFrames not working with ABE enabled

Posted: Wed Jul 29, 2009 5:42 pm
by Giorgio Maone
Should be fixed in latest development build 1.9.7.3.
Please test it intensively, because I think it deserves to be pushed it for automatic update in 6 hours if it does not cause any major regression.

Re: noscript.forbidIFrames not working with ABE enabled

Posted: Wed Jul 29, 2009 6:40 pm
by Mike A.
I have verified this reported bug is fixed with the 1.9.7.3 development build. Thanks for the fast support. Cheers!