Page 1 of 1

noscript with tabutils and ff33

Posted: Wed Oct 22, 2014 3:48 pm
by 79c36abbb2587a1bfd2a
what the story is about:
i. ff 32.0.2 with clean new profile, fresh noscript 2.6.9.2, fresh tab utilities 1.5.28.1 (by ithinc, amo) -- everything is fine
ii. ff 33.0, tabutils 1.5.28.1 -- broken urlbar (open about:newtab page, enter an address and nothing happens, empty field & page doesn't load; with already loaded page, from link or searchbar, works as expected)
iii. ff 33.0, tabutils v1.5.28.1-fix (by yfdyh000, https://github.com/yfdyh000/tabutils/releases) -- everything is fine
iv. ff 33.0, noscript 2.6.9.2, tabutils v1.5.28.1-fix -- broken anew
v. ff 33.0, noscript 2.6.9.2 -- everything is fine
vi. ff 34.0b2 -- same here

so, any quick thoughts about this one (https://github.com/yfdyh000/tabutils/commit/d9f8e29) commit?

Re: noscript with tabutils and ff33

Posted: Sun Oct 26, 2014 7:53 pm
by 79c36abbb2587a1bfd2a
action two, and
vii. doesn't relate to any about:config preference
viii. little bit of grepping, commented out noscriptBM.js's init() and voila!

handleURLBarCommandOriginal with changed handleCommand() method are just currious, isn't it a good time for attention and something renewed, called "Fx 33 and above command bar interception", huh? seems necessary

Re: noscript with tabutils and ff33

Posted: Wed Nov 12, 2014 12:35 pm
by therube
Bump @ Giorgio, anything here to do?

Re: noscript with tabutils and ff33

Posted: Thu Dec 25, 2014 6:12 pm
by 79c36abbb2587a1bfd2a
up, for the sake of christmas / therube, did you have any inner talk about it previously or thereafter?

Re: noscript with tabutils and ff33

Posted: Thu Dec 25, 2014 7:01 pm
by Giorgio Maone
79c36abbb2587a1bfd2a wrote:and something renewed, called "Fx 33 and above command bar interception", huh? seems necessary
Nope. The problem is TU_hookCode() using a very fragile method of monkeypatching Firefox's internal functions by replacing the source code with regular expressions and recompiling it.
NoScript just proxies it (which means it's must more resilient to changes in Firefox's code), but unfortunately this means the original source is not exposed anymore for monkeypatching.
Not much to do really here, other than either TabUtils converting to a more robust patching approch, or NoScript introduce an elaborate exceptional path to allow TabUtils do its trick :(