Page 1 of 1
Unhappy with renaming fix
Posted: Tue Oct 14, 2014 11:59 am
by gorsan
i hope i can explain this correctly
in flashgot 1.5.6.5 everything was working correctly
when i was downloading from a flash video site it was taking video name from that header or description of video site
example: spartakus_season5_episode4_blabla.mp4
now with latest patches it just takes the file name fron the source of that video site vk.me or mail.ru
example:sp342353.mp4
it is quite disturbing this renaming issue breaks all flash videos renaming
Re: Unhappy with renaming fix
Posted: Tue Oct 14, 2014 3:59 pm
by Giorgio Maone
May I see an actual example with URLs (you can PM or
email me, if you prefer)?
Did you try
downgrading to check whether it's actually a regression or a website change?
Thank you!
Re: Unhappy with renaming fix
Posted: Tue Oct 14, 2014 4:26 pm
by gorsan
sorry these sites are in turkish you will just have to click "reklami gec" link to reach these streaming videos
http://www.dizibox.org/the-originals-2- ... um-izle/2/
when i try to download this with old version of flashgot
the name of streaming video file is
The_orginals_2_sezon_2_bolum_720p.mp4 (whatever host i choose same name it just picks header of linker webpage)
when i try new version of flashgot it is
originaller2x2hdsi_5141.mp4 (if i download from mailru)
video_ext_d1fb.mp4 (if i choose vk.me etc)
Re: Unhappy with renaming fix
Posted: Wed Oct 15, 2014 9:17 am
by flashgot.user
Thats because I modified MediaSniffer to get the video title from the stream document (e.g. embed iframe) and not the top window. This version has the old behavior y default:
Code: Select all
http://rghost.net/private/58532640/204631ee83bf0848648005b749fed026
Those who want the new behavior, set
flashgot.media.use_iframe_title to true.
Also, it can group parsed YouTube streams by video, for pages like
this one. Grouping is disabled by default. When enabled, right-clicking a video group menu item will copy the video title and link to clipboard. Related preferences:
flashgot.media.YouTube.group - boolean - whether to group streams by video: true = group, false = don't.
flashgot.media.YouTube.group.title_max_length - integer - maximum video title length to use for menu item labels. Default is 40.
Re: Unhappy with renaming fix
Posted: Wed Oct 15, 2014 9:27 am
by Giorgio Maone
flashgot.user wrote:This version has the old behavior y default
Thank you!
Re: Unhappy with renaming fix
Posted: Wed Oct 15, 2014 6:14 pm
by gorsan
so here is what has to be done for less experienced users
you type as browser url about:config
add a new boolen by right clicking
for the name type flashgot.media.use_iframe_title
then choose false
thanks so much for the help
Re: Unhappy with renaming fix
Posted: Wed Oct 15, 2014 7:57 pm
by Giorgio Maone
Please check
latest development build 1.5.6.8.rc1, thank you.
Re: Unhappy with renaming fix
Posted: Thu Oct 16, 2014 8:31 am
by flashgot.user
gorsan wrote:for the name type flashgot.media.use_iframe_title
then choose false
This is unnecessary because the pref is false by default.
@
Giorgio
Sorry, I messed up again, this time when merging. Forgot to merge one line in MediaSniffer.js. The good news is that nobody will notice it because it's related to the new title behavior and happens in just one specific case, namely, with YouTube DASH streams (only SWF player uses them). And since that behavior is off by default and no one reads the forums/release notes, no one will ever turn it on. :) And you don't really need the entry for the use_iframe_title pref in flashgot.js since it's false by default - see MediaSniffer.js, line 337. Anyway, here's the fixed version:
Code: Select all
http://rghost.net/private/58549668/0b1afbdef3d4d56df68e994b9c09f96c
Re: Unhappy with renaming fix
Posted: Thu Oct 16, 2014 8:49 am
by flashgot.user
flashgot.user wrote:flashgot.media.YouTube.group - boolean
I meant
flashgot.media.YouTube.group.enabled.