InformAction Forums

[ ] Open permissions menu when mouse hovers over NoScript's icon <-- Option A
...[ ] Left clicking on NoScript toolbar button toggles permissions for current top level site <-- Option B

First glitch:
Option A is checked. You unchecked it.
Then Option B will be checked, but its sub-options are all greyed out.
You have to uncheck and recheck it to choose the sub-options.

Second glitch:
Change those options several times (select one option > press OK. Select another > OK. Repeat).
Then no matter which one I check later on, the behavior is always "Open permissions menu when mouse hovers over NoScript's icon"
It seems the option is getting "locked" due to some bug.
You have to restart Firefox to "unlock" it.

Thank you for your attention.

ReporterX wrote:

[ ] Open permissions menu when mouse hovers over NoScript's icon <-- Option A
...[ ] Left clicking on NoScript toolbar button toggles permissions for current top level site <-- Option B

First glitch:
Option A is checked. You unchecked it.
Then Option B will be checked, but its sub-options are all greyed out.
You have to uncheck and recheck it to choose the sub-options.

Confirmed. I think I'll take a shot at making a patch for this a bit later today.

ReporterX wrote:Second glitch:
Change those options several times (select one option > press OK. Select another > OK. Repeat).
Then no matter which one I check later on, the behavior is always "Open permissions menu when mouse hovers over NoScript's icon"
It seems the option is getting "locked" due to some bug.
You have to restart Firefox to "unlock" it.

Not seeing that, SeaMonkey 2.28 on Linux...
Australis related bug?

barbaz wrote:I think I'll take a shot at making a patch for this a bit later today.

Took a look at it, and I'm not sure how to fix it without using hacks, so I won't be providing a patch atm, sorry

What's happening is that the enabled/disabled state of the radio buttons gets set via an event listener for "command" on the "Left-clicking..." checkbox, but there's no relevant listener for command event from the "Open permissions menu..." checkbox, so the case where at the time of opening the NS Options, "Left-clicking..." and "Open permissions menu..." are both checked, isn't covered.

barbaz wrote:Took a look at it, and I'm not sure how to fix it without using hacks, so I won't be providing a patch atm, sorry

What's happening is that the enabled/disabled state of the radio buttons gets set via an event listener for "command" on the "Left-clicking..." checkbox, but there's no relevant listener for command event from the "Open permissions menu..." checkbox, so the case where at the time of opening the NS Options, "Left-clicking..." and "Open permissions menu..." are both checked, isn't covered.

I see.

IMHO the menu of that part should be redesigned.
All should use radio buttons, instead of checkboxes + radio buttons.

( ) Open permissions menu when mouse hovers over NoScript's icon <-- Option A
( ) Left clicking on NoScript toolbar button toggles permissions for current top level site <-- Option B
... ( ) Full Addresses
... ( ) Full Doamins
... ( ) Base 2nd level Domains

If Option A is selected, Option B will be deselected. Option B's sub-options will be greyed out.
If Option B is selected, Option A will be deselected. Option B's sub-options will be ungreyed out.

barbaz wrote:

ReporterX wrote:Second glitch:
Change those options several times (select one option > press OK. Select another > OK. Repeat).
Then no matter which one I check later on, the behavior is always "Open permissions menu when mouse hovers over NoScript's icon"
It seems the option is getting "locked" due to some bug.
You have to restart Firefox to "unlock" it.

Not seeing that, SeaMonkey 2.28 on Linux...
Australis related bug?

It might take some effort to trigger this bug.
I just kept trying until I got that bug. I got it two times, but I'm still not sure the exact steps of reproducing this bug.
Don't want to restart Firefox atm so not trying now.

ReporterX wrote:IMHO the menu of that part should be redesigned.
All should use radio buttons, instead of checkboxes + radio buttons.

( ) Open permissions menu when mouse hovers over NoScript's icon <-- Option A
( ) Left clicking on NoScript toolbar button toggles permissions for current top level site <-- Option B
... ( ) Full Addresses
... ( ) Full Doamins
... ( ) Base 2nd level Domains

If Option A is selected, Option B will be deselected. Option B's sub-options will be greyed out.
If Option B is selected, Option A will be deselected. Option B's sub-options will be ungreyed out.

No it shouldn't, because with radio buttons there's no way to deselect all of them. Try un-checking both Option A and Option B, and compare that behavior to when one or the other is checked.
So basically, if it's redesigned the way you're suggesting, an extra option would need to be added to the GUI, thus taking up more space, which is not an insignificant problem for NS.

barbaz wrote:

ReporterX wrote:IMHO the menu of that part should be redesigned.
All should use radio buttons, instead of checkboxes + radio buttons.

( ) Open permissions menu when mouse hovers over NoScript's icon <-- Option A
( ) Left clicking on NoScript toolbar button toggles permissions for current top level site <-- Option B
... ( ) Full Addresses
... ( ) Full Doamins
... ( ) Base 2nd level Domains

If Option A is selected, Option B will be deselected. Option B's sub-options will be greyed out.
If Option B is selected, Option A will be deselected. Option B's sub-options will be ungreyed out.

No it shouldn't, because with radio buttons there's no way to deselect all of them. Try un-checking both Option A and Option B, and compare that behavior to when one or the other is checked.
So basically, if it's redesigned the way you're suggesting, an extra option would need to be added to the GUI, thus taking up more space, which is not an insignificant problem for NS.

Think twice. Both options shouldn't be mutually exclusive.
If a user wants to hover to open up the permission menu and left click to toggle permissions, why not?
A simpler fix is to let a user enable both options.

ReporterX wrote:If a user wants to hover to open up the permission menu and left click to toggle permissions, why not?

Found this topic in my subscription list, and would like to note viewtopic.php?f=7&t=20319 along those lines