Page 1 of 1

[Resolved] Can't drag links to tab bar, Tree Style Tab

Posted: Wed Jul 23, 2014 9:38 pm
by Infocatcher
Just try to drop any link to tab bar: nothing happens and all draggable things (links, bookmarks, etc.) becomes not draggable.

Tested with Firefox 31.0, NoScript 2.6.8.33, 2.6.8.34, Tree Style Tab 0.14.2014051101, 0.14.2014070300a020408 (latest).

Also all works fine in Firefox 30.0.

P.S. Corresponding issue for Tree Style Tab (since I don't understand, who causes this bug):
https://github.com/piroor/treestyletab/issues/748

Re: Can't drag links to tab bar, if installed Tree Style Tab

Posted: Wed Jul 23, 2014 9:56 pm
by Infocatcher
Interesting, all works fine without following code:
noscript.jar\content\noscript\noscriptBM.js

Code: Select all

  delayedInit: function() {
    for each (let f in ["getShortcutOrURIAndPostData" /* Fx >= 25 */, "getShortcutOrURI"]) {
      if (f in window) {
        let getShortcut = window[f];
        window[f] = function(aURL) {
          if ("gURLBar" in window && window.gURLBar) {
            window.gURLBar.originalShortcut = aURL;
          }
          return getShortcut.apply(window, arguments);
        }
        break;
      }
    }
https://bugzilla.mozilla.org/show_bug.cgi?id=989984 ?

[Upd]
Oh, yes, from Tree Style Tab:
modules\utils.js

Code: Select all

	getShortcutOrURI : function utils_getShortcutOrURI(aBrowserWindow, aURI)
	{
		if (aBrowserWindow.getShortcutOrURI) // Firefox 24 and older
			return aBrowserWindow.getShortcutOrURI(aURI);

		var getShortcutOrURIAndPostData = aBrowserWindow.getShortcutOrURIAndPostData;
		var done = false;
		if (getShortcutOrURIAndPostData.length == 2) {
			// Firefox 31 and later, after https://bugzilla.mozilla.org/show_bug.cgi?id=989984
			getShortcutOrURIAndPostData(aURI, function(aData) {
				aURI = aData.url;
				done = true;
			});
		}
		else {
			// Firefox 25-30
			Task.spawn(function() {
				var data = yield getShortcutOrURIAndPostData(aURI);
				aURI = data.url;
				done = true;
			});
		}
Looks like changes from NoScript breaks getShortcutOrURIAndPostData.length detection.

Re: Can't drag links to tab bar, if installed Tree Style Tab

Posted: Sat Jul 26, 2014 8:18 am
by Giorgio Maone
Could you check whether latest development build 2.6.8.36rc1 helps?

Re: Can't drag links to tab bar, if installed Tree Style Tab

Posted: Sat Jul 26, 2014 9:31 am
by Infocatcher
Giorgio Maone wrote:Could you check whether latest development build 2.6.8.36rc1 helps?
Thanks, all works fine with NoScript 2.6.8.36rc1. :)