NoScripters and WebSec nerds of all lands, unite!
https://forums.informaction.com/
Code: Select all
2013-09-10T22:15:10.420Z Skipping link https://download-installer.cdn.mozilla.net/pub/mozilla.org/firefox/releases/23.0.1/win32/en-US/Firefox%20Setup%20Stub%2023.0.1.exe: [Exception... "Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIDownloadManager.addDownload]" nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)" location: "JS frame :: chrome://flashgot/content/DMS.js :: FlashGotDM.initDMS/dm.performDownload/mozAddDownload :: line 2551" data: no]Warning: This interface is deprecated as of Firefox 26. Please use Downloads.jsm instead.
Finding the problem was not hard (I pointed the relevant docs in my previous post).user wrote:They should try harder, because I still was able to trace the error source despite the fucked up stacktrace.
Atenza wrote:Will there be an update of FlashGot for this problem ?
Giorgio Maone wrote:I'm trying to fix that ASAP.
Code: Select all
http://www.putlocker.com/file/985FEC33BF45A95A - click "Continue as free user", not "Download now".
http://www17.zippyshare.com/v/40150093/file.htmlDarn good job!user wrote:Try this:Code: Select all
http://www.putlocker.com/file/985FEC33BF45A95A - click "Continue as free user", not "Download now". http://www17.zippyshare.com/v/40150093/file.html
@user: BTW, are all those Components.isSuccessCode() checks you added in MediaSniffer meant to skip on internal redirections and fix the Youtube extra loads bug?Giorgio Maone wrote:Darn good job!user wrote:Try this:Code: Select all
http://www.putlocker.com/file/985FEC33BF45A95A - click "Continue as free user", not "Download now". http://www17.zippyshare.com/v/40150093/file.html
That's what I guessed too, but still handling POST-triggered download is required as a built-in feature of Firefox's download manager, and in the general case you can't rely on website to play nice or use common sense (a huge upload which gets serialized in memory as a JSON string could be used as a DOS attack).user wrote:The payloads won't be huge because we're talking about _down_loads, not _up_loads. The biggest payload I've seen was on some filehosting: about 2 KB, 10+ hidden form fields. But that's an "extreme" case, usually it'll be even less - just a download/request/transaction ID and/or a disposable request token to prevent request replay. For instance, Grooveshark's payload is about 100 bytes.
I choose to drop the one in onStateChange() instead, because as far as I can see it just calls observe() which is already guarded.user wrote: I think the one in the beginning of observe() can be safely dropped because if I'm not missing anything, observe() is called either by the browser (who, I think, won't call it for an incomplete/interrupted response) or by MediaSniffer::onStateChange
I already noticed and removed it, thanks. As much as I share your feelings about breaking stuff by fixing what's not broken, I'm part of that community too, and generally prefer to discuss such issues politely (like in "open a bug report", as I did) rather than creating hard feelings which don't get things fixed and alienate collaborative attitudesuser wrote:And before you merge: there's another comment (DMS.js, line 2566) that AMO auditors probably won't like. Although I don't understand why do you care about their likes. I thought their job is auditing the code, not approving the comments.
No, I lied, we need both. In onStateChange, the reason I check the |status| parameter and not channel.status is that the latter can be zero (which means success) even if |status| is not. Just try that repeated refresh thing and you'll see.Giorgio Maone wrote:I choose to drop the one in onStateChange() instead, because as far as I can see it just calls observe() which is already guarded.
Negative. Tried installing it twice and still not outputting the data past the header.Giorgio Maone wrote:Please check latest development build 1.5.5.9rc1, thank you.