Page 1 of 1

Poor performance in ClearClickHandler#rapidFire.check

Posted: Tue Jun 04, 2013 6:59 pm
by Ventero
Steps to reproduce:

1. Go to http://dump.ventero.de/xkcd1110/open.html
2. Open Firefox dev tools and start profiling
3. Scroll your mousewheel (rapidly - the faster you scroll the more noticable the effect is) for a few seconds to zoom in and out on different spots
4. Stop profiling

Result: approximately 30% of the runtime is spent in ClearClickHandler's rapidFire.check, leading to poor performance of the application itself.

This was tested with NoScript 2.6.6.3rc1 in Firefox 22, the site is marked as trusted and ClearClick protection is disabled on trusted sites.

Re: Poor performance in ClearClickHandler#rapidFire.check

Posted: Tue Jun 04, 2013 7:30 pm
by Giorgio Maone
Investigating, thank you.

Re: Poor performance in ClearClickHandler#rapidFire.check

Posted: Thu Jun 06, 2013 12:33 pm
by Giorgio Maone
Uhm, I get 0.5% spent in rapidFire.check, even though I could imagine some problem may actually happen since lots of mouseover events are generated automatically (in facts, 3.2% of the time is spent in onMouseOver@openseadragon.js:2781).
Notice I'm testing on Nightly (24), so either you've got some other add-on interfering (did you try on a clean profile) or Mozilla fixed (or introduced?) some event dispatch bug in the meanwhile.

Re: Poor performance in ClearClickHandler#rapidFire.check

Posted: Thu Jun 06, 2013 5:07 pm
by Ventero
I'm still able to reproduce this with a clean profile in FF22. In FF24, I'm only able to reproduce about 7% of time spent in rapidFire.check - while this is much better, it's still not ideal, especially because ClearClick protection is disabled on trusted sites. However, as this doesn't affect the application's performance anymore, consider this a "request for enhancement" instead of a bug ;)