Page 1 of 1

[Fixed]Attempt to fix JavaScript links - problem with spaces

Posted: Tue May 28, 2013 8:10 am
by asdf
Hello,

first of all a big thank you for the great Noscript addon!

I have enabled "Attempt to fix JavaScript links" in Options/Advanced/Untrusted and noticed that the link fix feature does not work if the link contains spaces (tested with NoScript version 2.6.6.2).
Here's one example: http://www.ikea.com/de/de/store/walldorf/offers
If I click on "Angebote vom 27.5. bis 1.6.2013" nothing happens. Since the site will probably change in the next days here's the relevant HTML source code:

Code: Select all

<a href="javascript:window.open('/ms/de_DE/img/local_store_info/walldorf/pdf_files/Flyer Tagesangebote KW 222013.pdf','800x600','scrollbars,resizable,width=800,height=600');void(0);">Angebote vom 27.5. bis 1.6.2013</a>
If the URL doesn't contain a space like on http://www.ikea.com/de/de/store/mannheim/offers

Code: Select all

<a href="javascript:window.open('/ms/de_DE/img/local_store_info/mannheim/pdf_files/2013_KW22.pdf','800x1000','toolbar,status,menubar,scrollbars,resizable,width=800,height=1000');void(0);"><br>Unsere Tagesangebote vom 27.5. bis 1.6.2013</a>
NS is able to fix the link.

Re: Attempt to fix JavaScript links - problem with spaces

Posted: Tue May 28, 2013 10:02 am
by Giorgio Maone
Investigating, thank you.

Re: Attempt to fix JavaScript links - problem with spaces

Posted: Tue May 28, 2013 8:27 pm
by Giorgio Maone
Please check latest development build 2.6.6.3rc1, thank you.

Re: Attempt to fix JavaScript links - problem with spaces

Posted: Thu May 30, 2013 9:36 am
by asdf
Problem solved in 2.6.6.3rc1. Many thanks for the fast fix! Keep up the great work!