Page 2 of 2
Re: 2.0rc8 introduced some placeholder and icon issues
Posted: Mon Nov 15, 2010 7:33 am
by Giorgio Maone
Sorry, nothing to do about it.
The placeholder creation needs to be deferred because DOM manipulation can't happen immediately due to architecture limitations.
Re: 2.0rc8 introduced some placeholder and icon issues
Posted: Mon Nov 15, 2010 8:02 am
by al_9x
Giorgio Maone wrote:Sorry, nothing to do about it.
The placeholder creation needs to be deferred because DOM manipulation can't happen immediately due to architecture limitations.
Placeholder creation was deferred in 2.0rc7 also, I am not suggesting it shouldn't be, the issue is how much. Are you not seeing the difference on the simple page above? In 2.0rc7 it's so quick, it's invisible. In 2.0.6rc1 it's longer, producing this flashing effect. Is there a reason it had to get longer? Are you not in control of this timing?
Re: 2.0rc8 introduced some placeholder and icon issues
Posted: Thu Nov 18, 2010 3:13 pm
by Giorgio Maone
Recent NoScript versions coalesce placeholder replacements with about a 400ms resolutions, which greatly improve overall page loading times.
I don't want to touch this rather complicated stuff for a cosmetic change, while it will likely undergo a major rewrite for e10s.
Re: 2.0rc8 introduced some placeholder and icon issues
Posted: Thu Nov 18, 2010 3:23 pm
by al_9x
Giorgio Maone wrote:Recent NoScript versions coalesce placeholder replacements with about a 400ms resolutions
Does it make sense for this to be configurable? Or does the current code rely on a specific value? If possible, I would experiment with something lower.
Re: 2.0rc8 introduced some placeholder and icon issues
Posted: Thu Nov 18, 2010 3:39 pm
by Giorgio Maone
It's hard-coded. Look inside noscriptOverlay.syncUI().
Re: 2.0rc8 introduced some placeholder and icon issues
Posted: Thu Nov 18, 2010 4:36 pm
by al_9x
Giorgio Maone wrote:It's hard-coded. Look inside noscriptOverlay.syncUI().
Can you make it configurable?