[FIXED] Garbled pop-up menu

[Guest]

Open NoScript options, then press the NoScript button to open the pop-up menu: it's small and shows all default buttons (though I've set a few to be hidden) and when clicking elsewhere a window (/ui/popup.html#tab14) will automatically open which has NoScript settings in the title, again shows all the default buttons of this menu but is otherwise blank.

[Giorgio Maone]

Thanks for reporting.
It seems a regression (or something I overlooked that went unnoticed so far, I must check whether is new or not), but definitely a bug: the browser action button should be disabled or the menu say "This is a privileged page, whose permissions cannot be configured." like it does in other non-content tabs.

[musonius]

I had that problem with a clean profile when I installed .19rc1 or .19rc2 from noscript.net yesterday as well. It exactly looked like Guest's description.

Another try and the popup was there but I could just see the headers of the options: at the first tab the headers DEFAULT, TRUSTED and UNTRUSTED, but without the options. The second tab was completely empty. Importing the settings helped.

Another try and everything was fine again. Until here I am talking about .19rc1 or .19rc2 installed from noscript.net.

I had no problems when I installed the release version .19 in the add-on manager of Firefox. The update to version .20 was fine as well. No problems at work where I installed version .20 on a clean profile.

Hope, that helps.

[barbaz]

NoScript 10.1.8.20rc1
Firefox 61.0.2
new profile

Title pretty much says it all. Clicking out of the popup brings up a separate window that is just blank.

Browser Console content after clearing, then opening NoScript Options, then opening the stuck popup -

Code: Select all

ReferenceError: ns is not defined[Learn More] d42b8942-65b3-4640-8aaa-1df738ce611a:1:1
ReferenceError: ns is not defined[Learn More] 9c7e276a-7516-4800-a14f-c9a5ee1abf2f:1:1
[NoScript] apply 
title="__MSG_Reveal__"
log.js:9:39
[NoScript] Including /ui/ui.css log.js:9:39
[NoScript] Including /lib/Messages.js log.js:9:39
[NoScript] Including /lib/punycode.js log.js:9:39
[NoScript] Including /lib/tld.js log.js:9:39
[NoScript] Including /common/Policy.js log.js:9:39
Cannot send function call result: other side closed connection (call data: ({path:"runtime.openOptionsPage", args:[]}))
[NoScript] Cannot collect noscript activity data Error: "Could not establish connection. Receiving end does not exist."
sendmoz-extension://f4e70f47-22f4-4dc6-a120-b48e5b3cde5e/lib/Messages.js:37:22 Could not establish connection. Receiving end does not exist. send@moz-extension://f4e70f47-22f4-4dc6-a120-b48e5b3cde5e/lib/Messages.js:37:22
log.js:12:62
persisted  null persistent-tabs.js:9:5
[NoScript] Including /ui/ui.css log.js:9:39
[NoScript] Including /lib/Messages.js log.js:9:39
[NoScript] Including /lib/punycode.js log.js:9:39
[NoScript] Including /lib/tld.js log.js:9:39
[NoScript] Including /common/Policy.js log.js:9:39
[NoScript] apply 
accesskey="__MSG_Import_accesskey__"
log.js:9:39
[NoScript] apply 
accesskey="__MSG_Export_accesskey__"
log.js:9:39
[NoScript] apply 
accesskey="__MSG_Reset_accesskey__"
log.js:9:39
[NoScript] apply 
accesskey="__MSG_CustomizePresets_accesskey__"
log.js:9:39
[NoScript] apply 
accesskey="__MSG_WebAddress_accesskey__"
log.js:9:39
[Show/hide message details.] Unknown localization message customizepresets_accesskey locale.js:10
[NoScript] apply 
title="__MSG_Reveal__"
log.js:9:39
[NoScript] Including /ui/ui.css log.js:9:39
[NoScript] Including /lib/Messages.js log.js:9:39
[NoScript] Including /lib/punycode.js log.js:9:39
[NoScript] Including /lib/tld.js log.js:9:39
[NoScript] Including /common/Policy.js log.js:9:39
[NoScript] Cannot collect noscript activity data Error: "Message manager disconnected"
sendmoz-extension://f4e70f47-22f4-4dc6-a120-b48e5b3cde5e/lib/Messages.js:37:22 Message manager disconnected send@moz-extension://f4e70f47-22f4-4dc6-a120-b48e5b3cde5e/lib/Messages.js:37:22
log.js:12:62
Ignoring response to aborted listener for 113
TypeError: Argument 1 of PrecompiledScript.executeInGlobal is not an object.
ExtensionContent.jsm:489:18
[NoScript] apply 
title="__MSG_Reveal__"
log.js:9:39
[NoScript] Including /ui/ui.css log.js:9:39
[NoScript] Including /lib/Messages.js log.js:9:39
[NoScript] Including /lib/punycode.js log.js:9:39
[NoScript] Including /lib/tld.js log.js:9:39
[NoScript] Including /common/Policy.js log.js:9:39
TypeError: this.contentWindow is null[Learn More]
ExtensionPageChild.jsm:191:5

[musonius]

Now I know how to reproduce it. Before exporting my rules for a backup I reset all temporary permissions. I often have done that with the current tab being the list with the site permissions. This worked fine so far and ceased to work now. It still worked with the relase candidates of version .17 amd may be broken since the last one or maybe the one before. I have just installed version .22, by the way, thus it is still broken.

[barbaz]

Threads merged, I somehow missed this one when reporting the same behavior, sorry.

[skriptimaahinen]

Fix:

in content.js:

Use listener for "onChildPolicy" instead of waiting return value for fetchChildPolicy.

in main.js:fetchChildPolicy

Instead of returning the value, send a new Message "onChildPolicy".

Message.js:

Now that we have avoided getting answer from a wrong listener, we can remove the popup "garbling" "await forever".

[musonius]

I have installed version 10.1.9rc3 and the pop-up works again. Thank you!

By the way, the text and the link to the latest development version still show rc2.

[barbaz]

I have installed version 10.1.9rc3 and the pop-up works again. Thank you!

10.1.9rc3 fixes it for me too, thanks Giorgio

While waiting for noscript.net to be updated, here's the download link: https://secure.informaction.com/downloa ... 1.9rc3.xpi

[musonius]

At the moment, after installing 10.1.9rc5, there is no popup in the options tab anymore.

Browser Console:

Code: Select all

[NoScript] Can't open popup <unavailable> Failed to load /lib/close(ricted.js include/loading</inc.onerror@moz-extension://e24e6080-0f8f-4123-8c11-1e4f4a7c4ecd/lib/include.js:29:34

This has been introduced in this commit ("Better timing feedback for permissions changes in the popup UI.").

*** EDIT: fixed in rc6 ***