[FIXED] Surrogates and moz-extension: pages

[barbaz]

NoScript 5.1.8.3rc1
Waterfox 56.0.1 (also seen in Firefox 56.0.2)
new profile

STR:

1) add this surrogate -

Code: Select all

noscript.surrogate.foo.replacement : Object.defineProperty(window, 'innerWidth', {value:5000});
noscript.surrogate.foo.sources : @*

2) install uBlock Origin webext version from https://addons.mozilla.org/addon/ublock-origin/

3) open uBlock Origin dashboard > Settings, check "I am an advanced user"

4) open the uBlock Origin popup

Expected results: popup opens normally

Actual results: popup is badly messed up, stretched out so much it's not readable.

While this can be worked around by adding moz-extension: to the surrogate's .exceptions pref, I don't think this should be happening at all. Surrogates were never intended to modify other extensions.

Giorgio, can you please make so that surrogates don't apply to moz-extension: URLs? Thanks!

[Giorgio Maone]

Please check latest development build, thanks:

v 5.1.6.4rc1
=============================================================
x [XSS] Fixed false positives on badly encoded URLs (thanks
sage11 for reporting)
x Script Surrogates don't affect privileged URLs anymore,
unless the noscript.surrogate.matchPrivileged about:config
preference is set to true (thanks barbaz for RFE)
x [e10s] Fixed temporary permissions inter-process sync issue
(thanks to the TorBrowser team for solution)

[barbaz]

Fixed, thanks!

Although I had to restart my browser with -purgecaches command-line option for the fix to apply.
https://developer.mozilla.org/docs/Mozi ... ne_Options