Hi,
starting with NoScript version 5.1.6rc1 I can't no more edit ABE rules.
Relevant (?) console error:
FireFox 52.5 ESR and SeaMonkey 2.49.1 - Debian Stable x86_64 in a new, clean profile.
No problem with NoScript version 5.1.5
[FIXED] Can't edit ABE rules
[FIXED] Can't edit ABE rules
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0
Re: Can't edit ABE rules
I see the same problem in NoScript 5.1.7rc1.
*Always* check the changelogs BEFORE updating that important software!
-
Re: Can't edit ABE rules
Still broken in 5.1.8.1.
The relevant code in 5.1.8.1 -
Looks like this bug might just be a typo?
The relevant code in 5.1.8.1 -
Code: Select all
saveRuleset: function(name, source) {
COMPAT.setStringPref(this.prefs, "rulesets." + name, str);
},
*Always* check the changelogs BEFORE updating that important software!
-
Re: Can't edit ABE rules
Can confirm, still broken for me too in 5.1.8.1.barbaz wrote:Still broken in 5.1.8.1.
Also broken on current TOR Browser, I just checked out of curiosity.
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0
Re: Can't edit ABE rules
And indeed, this patch looks to fix the problem -barbaz wrote:Still broken in 5.1.8.1.
The relevant code in 5.1.8.1 -Looks like this bug might just be a typo?Code: Select all
saveRuleset: function(name, source) { COMPAT.setStringPref(this.prefs, "rulesets." + name, str); },
Code: Select all
diff --git a/chrome/content/noscript/ABE.js b/chrome/content/noscript/ABE.js
--- a/chrome/content/noscript/ABE.js
+++ b/chrome/content/noscript/ABE.js
@@ -1257,7 +1257,7 @@
},
saveRuleset: function(name, source) {
- COMPAT.setStringPref(this.prefs, "rulesets." + name, str);
+ COMPAT.setStringPref(this.prefs, "rulesets." + name, source);
},
persist: function() {
*Always* check the changelogs BEFORE updating that important software!
-
- Giorgio Maone
- Site Admin
- Posts: 9454
- Joined: Wed Mar 18, 2009 11:22 pm
- Location: Palermo - Italy
- Contact:
Re: Can't edit ABE rules
Merging, thanks!
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
Re: Can't edit ABE rules
Fixed in 5.1.8.2rc6
*Always* check the changelogs BEFORE updating that important software!
-
Re: Can't edit ABE rules
Hooray!barbaz wrote:Fixed in 5.1.8.2rc6
And how do you get that dancing banana smiley?
Mozilla/5.0 (X11; Linux x86_64; rv:52.9) Gecko/20100101 Goanna/3.4 Firefox/52.9 PaleMoon/27.6.2