[FIXED] Can't edit ABE rules

Bug reports and enhancement requests
Post Reply
Rollo
Junior Member
Posts: 26
Joined: Wed Dec 17, 2014 11:59 am

[FIXED] Can't edit ABE rules

Post by Rollo » Sat Nov 18, 2017 3:26 pm

Hi,
starting with NoScript version 5.1.6rc1 I can't no more edit ABE rules.
Relevant (?) console error:
Image

FireFox 52.5 ESR and SeaMonkey 2.49.1 - Debian Stable x86_64 in a new, clean profile.
No problem with NoScript version 5.1.5
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0

barbaz
Senior Member
Posts: 9227
Joined: Sat Aug 03, 2013 5:45 pm

Re: Can't edit ABE rules

Post by barbaz » Sat Nov 18, 2017 3:40 pm

I see the same problem in NoScript 5.1.7rc1.
*Always* check the changelogs BEFORE updating that important software!
-

barbaz
Senior Member
Posts: 9227
Joined: Sat Aug 03, 2013 5:45 pm

Re: Can't edit ABE rules

Post by barbaz » Tue Dec 05, 2017 5:34 am

Still broken in 5.1.8.1.

The relevant code in 5.1.8.1 -

Code: Select all

  saveRuleset: function(name, source) {
    COMPAT.setStringPref(this.prefs, "rulesets." + name, str);
  },
Looks like this bug might just be a typo?
*Always* check the changelogs BEFORE updating that important software!
-

Rollo
Junior Member
Posts: 26
Joined: Wed Dec 17, 2014 11:59 am

Re: Can't edit ABE rules

Post by Rollo » Tue Dec 05, 2017 8:01 am

barbaz wrote:Still broken in 5.1.8.1.
Can confirm, still broken for me too in 5.1.8.1.
Also broken on current TOR Browser, I just checked out of curiosity.
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0

barbaz
Senior Member
Posts: 9227
Joined: Sat Aug 03, 2013 5:45 pm

Re: Can't edit ABE rules

Post by barbaz » Fri Dec 08, 2017 4:33 am

barbaz wrote:Still broken in 5.1.8.1.

The relevant code in 5.1.8.1 -

Code: Select all

  saveRuleset: function(name, source) {
    COMPAT.setStringPref(this.prefs, "rulesets." + name, str);
  },
Looks like this bug might just be a typo?
And indeed, this patch looks to fix the problem -

Code: Select all

diff --git a/chrome/content/noscript/ABE.js b/chrome/content/noscript/ABE.js
--- a/chrome/content/noscript/ABE.js
+++ b/chrome/content/noscript/ABE.js
@@ -1257,7 +1257,7 @@
   },
 
   saveRuleset: function(name, source) {
-    COMPAT.setStringPref(this.prefs, "rulesets." + name, str);
+    COMPAT.setStringPref(this.prefs, "rulesets." + name, source);
   },
 
   persist: function() {
*Always* check the changelogs BEFORE updating that important software!
-

User avatar
Giorgio Maone
Site Admin
Posts: 8715
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: Can't edit ABE rules

Post by Giorgio Maone » Fri Dec 08, 2017 8:58 pm

Merging, thanks!
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

barbaz
Senior Member
Posts: 9227
Joined: Sat Aug 03, 2013 5:45 pm

Re: Can't edit ABE rules

Post by barbaz » Fri Dec 08, 2017 11:48 pm

Fixed in 5.1.8.2rc6 Image
*Always* check the changelogs BEFORE updating that important software!
-

User avatar
gracious1
Junior Member
Posts: 20
Joined: Sat Sep 16, 2017 7:33 pm

Re: Can't edit ABE rules

Post by gracious1 » Sat Dec 09, 2017 7:19 pm

barbaz wrote:Fixed in 5.1.8.2rc6 Image
Hooray!
And how do you get that dancing banana smiley?
Mozilla/5.0 (X11; Linux x86_64; rv:52.9) Gecko/20100101 Goanna/3.4 Firefox/52.9 PaleMoon/27.6.2

Post Reply