[FIXED] Can't edit ABE rules

[Rollo]

Hi,
starting with NoScript version 5.1.6rc1 I can't no more edit ABE rules.
Relevant (?) console error:


FireFox 52.5 ESR and SeaMonkey 2.49.1 - Debian Stable x86_64 in a new, clean profile.
No problem with NoScript version 5.1.5

[barbaz]

I see the same problem in NoScript 5.1.7rc1.

[barbaz]

Still broken in 5.1.8.1.

The relevant code in 5.1.8.1 -

Code: Select all

  saveRuleset: function(name, source) {
    COMPAT.setStringPref(this.prefs, "rulesets." + name, str);
  },

Looks like this bug might just be a typo?

[Rollo]

Still broken in 5.1.8.1.

Can confirm, still broken for me too in 5.1.8.1.
Also broken on current TOR Browser, I just checked out of curiosity.

[barbaz]

Still broken in 5.1.8.1.

The relevant code in 5.1.8.1 -

Code: Select all

  saveRuleset: function(name, source) {
    COMPAT.setStringPref(this.prefs, "rulesets." + name, str);
  },

Looks like this bug might just be a typo?

And indeed, this patch looks to fix the problem -

Code: Select all

diff --git a/chrome/content/noscript/ABE.js b/chrome/content/noscript/ABE.js
--- a/chrome/content/noscript/ABE.js
+++ b/chrome/content/noscript/ABE.js
@@ -1257,7 +1257,7 @@
   },
 
   saveRuleset: function(name, source) {
-    COMPAT.setStringPref(this.prefs, "rulesets." + name, str);
+    COMPAT.setStringPref(this.prefs, "rulesets." + name, source);
   },
 
   persist: function() {

[Giorgio Maone]

Merging, thanks!

[barbaz]

Fixed in 5.1.8.2rc6

[gracious1]

Fixed in 5.1.8.2rc6

Hooray!
And how do you get that dancing banana smiley?