2.9.5.2rc1 Delay changing permissions, sticky UI issue

[mechadon]

There are still 2 problems I'm experiencing in the latest build of NoScript.

1) When allowing/forbidding for each element, there is a delay: the mouse pointer becomes the loading ring for about a second. This never happened before, clicking an element is usually instantaneous. It's a problem when several things must be forbidden/allowed.

2) On rarer occasions, Noscript disappears after allowing (but not forbidding) just one site at a time. I read that this was partly an old behavior of the menu before the sticky UI. Except here, this is only happening when allowing, and not forbidding, sites and it comes and goes; plus, the noscript.stickyUI is set to true in about:config. I experienced this bug before the rc31 update, but it was rarer. EDIT: Actually, this problem seems way more frequent.

[Giorgio Maone]

1) When allowing/forbidding for each element, there is a delay: the mouse pointer becomes the loading ring for about a second. This never happened before, clicking an element is usually instantaneous. It's a problem when several things must be forbidden/allowed.

There's no actual delay, but Firefox gives you feedback because the reload is now actually an asynchronous operation, which ideally (if e10s is enabled) happens in a different process. Even if you've got the spinning ring as a cursor, you can keep operating on the menu.

2) On rarer occasions, Noscript disappears after allowing (but not forbidding) just one site at a time. I read that this was partly an old behavior of the menu before the sticky UI. Except here, this is only happening when allowing, and not forbidding, sites and it comes and goes; plus, the noscript.stickyUI is set to true in about:config. I experienced this bug before the rc31 update, but it was rarer. EDIT: Actually, this problem seems way more frequent.

This may happen if the menu, as a result of the new permissions, shrinks itself making the cursor go off it.
Next time it happens could you please right click on the "About NoScript" menu item and paste here the sites list you get in the clipboard as a result?

[mechadon]

There's no actual delay, but Firefox gives you feedback because the reload is now actually an asynchronous operation, which ideally (if e10s is enabled) happens in a different process. Even if you've got the spinning ring as a cursor, you can keep operating on the menu.

I tested this and I cannot click on anything else in the menu until the ring stops spinning and reverts to the pointer.

This may happen if the menu, as a result of the new permissions, shrinks itself making the cursor go off it.
Next time it happens could you please right click on the "About NoScript" menu item and paste here the sites list you get in the clipboard as a result?

Usually the cursor doesn't go off like that; I've never had that situation occur, at least. I'll try to reproduce the behavior now and will report back with the list of sites. It's worth noting that it sometimes happens on one tab, but then the issue can disappear a short while later (before returning random).
EDIT: I have the problem occurring on a tab with google.ca right now; I cannot right-click the about noscript 2.9.5rc33 menu item, though.

[Giorgio Maone]

EDIT: I have the problem occurring on a tab with google.ca right now; I cannot right-click the about noscript 2.9.5rc33 menu item, though.

You don't get any feedback for right-clicking, so you may believe "you cannot".
Just try to paste in a text field after that, you should get a domains list.

[mechadon]

Oh, I see now, thanks.
One site shows up:
+google.ca-gstatic.com

[barbaz]

Er, that's supposed to be two sites, listed like this -

Code: Select all

+google.ca
-gstatic.com

[mechadon]

Oh, I see. That's how it was listed when I pasted it in notepad (then copy-pasted onto here), all in 1 line.

EDIT: I want to elaborate on the delay I mentioned above.
I do think it's a delay, not just because the mouse becomes the spinning ring for a second, but the actual menu item doesn't change for that second in the menu. In other words, in the menu, it's supposed to change immediately from "Temporarily allow site (and Allow site)" to "Forbid (site)", and vice versa. But it doesn't; before the bug with rc27, it would change immediately in the menu (and no loading ring).

[mechadon]

Both problems disappeared when updating to 2.9.5.1, but only temporarily. They were gone for a day, but then came back; updated to 2.9.5.2rc1 and still experiencing these 2 problems. Not sure how they were fixed by updating, even though only for a short while.

[Giorgio Maone]

OK, I've observed it.
It's just a cosmetic issue, due to the menu waiting for the content process to notify back the reload happened before updating the UI reflecting all the changes, both in the permissions and in the attempted loads list.
I'm fixing it by forcing a synchronous UI update immediately, just to reflect the new permissions, and then wait for the notification from the content process as usual.

[Giorgio Maone]

Fixed in latest development build 2.9.5.2rc2, thanks.

[mechadon]

Perfect, thanks a lot for this fix. I'll update it now.