memory leak when allowing twnmm.com in The Weather Network

Bug reports and enhancement requests
jongor
Posts: 9
Joined: Sun Mar 06, 2016 12:33 am

memory leak when allowing twnmm.com in The Weather Network

Post by jongor »

I've been experiencing a horrible memory loss using Firefox 44.0.2 which I've discovered is being caused by visiting The Weather Network and having NoScript enabled. If it's disabled, no memory leak occurs. If it's enabled and I have twnmm.com blocked, no memory leak occurs, but I lose graphic files on the site. If NoScript is enabled and twnmm.com isn't blocked, the memory loss begins; in a few minutes, it's over 50 Meg and growing, eventually to over 7 Gigs of ram (thanks to Tab Memory Usage extension for the info, although it's also shown in Windows Tast Manager processes). I'm using the latest development version of NoScript (2.9.0.4rc1, I believe). The memory leak is so severe, my computer eventually reboots.
Last edited by barbaz on Fri Mar 11, 2016 3:34 am, edited 1 time in total.
Reason: fix typo in thread title
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:44.0) Gecko/20100101 Firefox/44.0
gorhill
Junior Member
Posts: 48
Joined: Sun Mar 30, 2014 12:19 pm

Re: memory leak when allowing twinmm.com in The Weather Netw

Post by gorhill »

It's not NoScript's fault, it's the site's fault -- a similar issue was opened on my side. The culprit script which contains the flawed code on that site is

Code: Select all

http://s1.twnmm.com/js/fr_ca/r1309011/modernizr/dfpad/s_code/adb_dil/adobe_audience_manager
Some sites are so bent on tracking/data mining you that they will sabotage themselves (voluntarily or not) if you do not let them do so.
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:44.0) Gecko/20100101 Firefox/44.0
User avatar
Thrawn
Master Bug Buster
Posts: 3106
Joined: Mon Jan 16, 2012 3:46 am
Location: Australia
Contact:

Re: memory leak when allowing twinmm.com in The Weather Netw

Post by Thrawn »

You may be able to stop this using ABE (Options-Advanced-ABE), adding to the USER ruleset:

Code: Select all

Site ^.*\.twnmm\.com/js/.*/adobe_audience_manager
Deny
======
Thrawn
------------
Religion is not the opium of the masses. Daily life is the opium of the masses.

True religion, which dares to acknowledge death and challenge the way we live, is an attempt to wake up.
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:44.0) Gecko/20100101 Firefox/44.0
barbaz
Senior Member
Posts: 11070
Joined: Sat Aug 03, 2013 5:45 pm

Re: memory leak when allowing twinmm.com in The Weather Netw

Post by barbaz »

To make into new default surrogate script needed?
*Always* check the changelogs BEFORE updating that important software!
-
jongor
Posts: 9
Joined: Sun Mar 06, 2016 12:33 am

Re: memory leak when allowing twinmm.com in The Weather Netw

Post by jongor »

Thrawn wrote:You may be able to stop this using ABE (Options-Advanced-ABE), adding to the USER ruleset:

Code: Select all

Site ^.*\.twnmm\.com/js/.*/adobe_audience_manager
Deny
Many, many thanks Thrawn - Implemented 10 minutes ago, and appears to be working flawlessly!!! Nice to get my Weather Network videos working again!

Cheers,

jongor
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:44.0) Gecko/20100101 Firefox/44.0
User avatar
Thrawn
Master Bug Buster
Posts: 3106
Joined: Mon Jan 16, 2012 3:46 am
Location: Australia
Contact:

Re: memory leak when allowing twinmm.com in The Weather Netw

Post by Thrawn »

Good to hear it's resolved.

As barbaz suggested, probably the best long-term fix for a specific site issue like this would be a surrogate script (ABE works fine, but isn't really optimised for this job). It might take some time to investigate the offending script and write a good one, though. Anyone interested?
======
Thrawn
------------
Religion is not the opium of the masses. Daily life is the opium of the masses.

True religion, which dares to acknowledge death and challenge the way we live, is an attempt to wake up.
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:44.0) Gecko/20100101 Firefox/44.0
barbaz
Senior Member
Posts: 11070
Joined: Sat Aug 03, 2013 5:45 pm

Re: memory leak when allowing twinmm.com in The Weather Netw

Post by barbaz »

Sure, I'll try my hand at it.

EDIT I can reproduce the problem and then un-reproduce it, but a fix will be elusive. More than one surrogate will need updating here, maybe even need to create a new surrogate...
EDIT2 This is the state of the NoScript menu required to avoid the memory issue, minimal permissions (after Allowing twnmm):

Code: Select all

+meteomedia.com
-scorecardresearch.com
-optimizely.com
-facebook.net
-indexww.com
+googleadservices.com
-demdex.net
+twnmm.com
-crazyegg.com
+googlesyndication.com
+google-analytics.com
+googletagmanager.com
+googletagservices.com
-doubleclick.net
The scripts that are Allowed don't all show up at once, but show up cascading. No idea what to do with that :(
*Always* check the changelogs BEFORE updating that important software!
-
jongor
Posts: 9
Joined: Sun Mar 06, 2016 12:33 am

Re: memory leak when allowing twnmm.com in The Weather Netwo

Post by jongor »

I hate to post this update, but my memory leak has returned - same site is causing the problem, and the fix still seems to be there (but obviously not working).... Any further suggestions?

Thanks,

jongor
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:45.0) Gecko/20100101 Firefox/45.0
barbaz
Senior Member
Posts: 11070
Joined: Sat Aug 03, 2013 5:45 pm

Re: memory leak when allowing twnmm.com in The Weather Netwo

Post by barbaz »

Does my EDIT2 above still the case? (can't check atm)
*Always* check the changelogs BEFORE updating that important software!
-
jongor
Posts: 9
Joined: Sun Mar 06, 2016 12:33 am

Re: memory leak when allowing twnmm.com in The Weather Netwo

Post by jongor »

Thanks for the quick reply. I used ABE for the last code, but it sounds like I need to use another implementation for this surrogate script - could you please describe how to use it?

Cheers,

jongor
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:45.0) Gecko/20100101 Firefox/45.0
barbaz
Senior Member
Posts: 11070
Joined: Sat Aug 03, 2013 5:45 pm

Re: memory leak when allowing twnmm.com in The Weather Netwo

Post by barbaz »

Don't know an implementation of surrogate at this point, probably we'll have to unify a few of our surrogates into one and hope it doesn't cause chaos. What I'm asking is if you set script permissions as shown in my above post (+ allowed, - Forbidden) does the memory leak still occur?
*Always* check the changelogs BEFORE updating that important software!
-
jongor
Posts: 9
Joined: Sun Mar 06, 2016 12:33 am

Re: memory leak when allowing twnmm.com in The Weather Netwo

Post by jongor »

Sorry for the misunderstanding - I thought your list was a script!

My list is a little different than yours:

- googletagservices.com
- googletagmanager.com
+ cbc.com
+ twnmm.com
- indexww.com
- feedbackify.com
- scorecardresearch.com
+ theweathernetwork.com

Hope this helps...
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:45.0) Gecko/20100101 Firefox/45.0
barbaz
Senior Member
Posts: 11070
Joined: Sat Aug 03, 2013 5:45 pm

Re: memory leak when allowing twnmm.com in The Weather Netwo

Post by barbaz »

Not quite. Please try (Temp-)Allowing every domain with "google" in it, until you don't get more google domains showing up. (This is what I had to do before.)
Does the memory leak go away then?

(Tip: you can right-click somewhere in the NoScript menu not on a site, e.g. on the About NoScript entry, and the whole script listing state will be copied and you can paste it like with Ctrl-V)
*Always* check the changelogs BEFORE updating that important software!
-
jongor
Posts: 9
Joined: Sun Mar 06, 2016 12:33 am

Re: memory leak when allowing twnmm.com in The Weather Netwo

Post by jongor »

Update: Disallowing twnmm.com solves memory problem, but introduces new (graphic formatting) ones...
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:45.0) Gecko/20100101 Firefox/45.0
jongor
Posts: 9
Joined: Sun Mar 06, 2016 12:33 am

Re: memory leak when allowing twnmm.com in The Weather Netwo

Post by jongor »

Allowing all domains with "Google" in it doesn't solve problem....
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:45.0) Gecko/20100101 Firefox/45.0
Post Reply