[Resolved] googletag surrogate broken on ebay kleinanzeigen

Proposals for new surrogate scripts, updates/bug fixes to existing ones, tips and tricks to work around the lazy web.
Post Reply
bgmnt
Junior Member
Posts: 47
Joined: Sun Nov 17, 2013 3:41 pm

[Resolved] googletag surrogate broken on ebay kleinanzeigen

Post by bgmnt » Tue Nov 17, 2015 12:37 pm

Hey,
I noticed that on ebay-kleinazeigen.de, I have to allow googletagservices.com in order to see the pictures in full.
Example link:
http://www.ebay-kleinanzeigen.de/s-anze ... 6-217-2053

If you click on the picture you are supposed to see them in big, however with not allowed googletagservices.com, one just sees a blank pop-up.


So something might not work with the surrogate here, can someone take a look?
Thanks!
Last edited by barbaz on Mon Nov 23, 2015 5:51 pm, edited 2 times in total.
Reason: mark as resolved
Mozilla/5.0 (X11; Linux x86_64; rv:41.0) Gecko/20100101 Firefox/41.0

barbaz
Senior Member
Posts: 9232
Joined: Sat Aug 03, 2013 5:45 pm

Re: googletagservices surrogate not working on ebay kleinanz

Post by barbaz » Tue Nov 17, 2015 1:03 pm

Just to make sure, are you using latest development build or NoScript 2.6.9.39 (both should be the same atm)?
*Always* check the changelogs BEFORE updating that important software!
-

bgmnt
Junior Member
Posts: 47
Joined: Sun Nov 17, 2013 3:41 pm

Re: googletagservices surrogate not working on ebay kleinanz

Post by bgmnt » Tue Nov 17, 2015 2:29 pm

barbaz wrote:Just to make sure, are you using latest development build or NoScript 2.6.9.39 (both should be the same atm)?
I'm using 2.6.9.39 .
Mozilla/5.0 (X11; Linux x86_64; rv:41.0) Gecko/20100101 Firefox/41.0

barbaz
Senior Member
Posts: 9232
Joined: Sat Aug 03, 2013 5:45 pm

Re: googletagservices surrogate not working on ebay kleinanz

Post by barbaz » Tue Nov 17, 2015 3:23 pm

OK, looking into it in just a moment...

UPD I can confirm the problem.
*Always* check the changelogs BEFORE updating that important software!
-

barbaz
Senior Member
Posts: 9232
Joined: Sat Aug 03, 2013 5:45 pm

Re: googletagservices surrogate not working on ebay kleinanz

Post by barbaz » Tue Nov 17, 2015 3:49 pm

fixed surrogate:

Code: Select all

if(typeof googletag==='undefined'){googletag={slots:{},cmd:$S({__noSuchMethod__:function()this,push:function(f){return f()}})};} googletag.defineSlot=function(){return $S({__noSuchMethod__:function(){},addService:function(){return $S({__noSuchMethod__:function(){return googletag.addService();}})}})};let _gt=googletag;googletag=new Proxy(_gt,{get:function(s,w,e){return w in s?s[w]:function(){return $S({__noSuchMethod__:function(){return googletag;}})};}});let _renderedAds=new Proxy({},{get:function(a,b){return b in a?a[b]:{size:[729,90]};},set:function(a,b,c){a[b]=c}});let _adsRenderedInfo=new Proxy({get:function(n){return _renderedAds[n];}},{get:function(x,c){return c in x?x[c]:function(){};},set:function(x,c,v){}});Object.defineProperty(googletag,'adsRenderedInfo',{enumerable:true,set:function(){},get:function(){return _adsRenderedInfo;}});
*Always* check the changelogs BEFORE updating that important software!
-

bgmnt
Junior Member
Posts: 47
Joined: Sun Nov 17, 2013 3:41 pm

Re: googletagservices surrogate not working on ebay kleinanz

Post by bgmnt » Tue Nov 17, 2015 7:00 pm

barbaz wrote:fixed surrogate:
...
Cool, thanks!
So I just wait for the update?
Mozilla/5.0 (X11; Linux x86_64; rv:41.0) Gecko/20100101 Firefox/41.0

barbaz
Senior Member
Posts: 9232
Joined: Sat Aug 03, 2013 5:45 pm

Re: googletagservices surrogate not working on ebay kleinanz

Post by barbaz » Tue Nov 17, 2015 7:07 pm

Basically yes, but in the mean time you could set about:config > set noscript.surrogate.googletag.replacement to the above code (but if you do that, remember to reset it to default value after the update so that you receive further updates to the surrogate).
*Always* check the changelogs BEFORE updating that important software!
-

barbaz
Senior Member
Posts: 9232
Joined: Sat Aug 03, 2013 5:45 pm

Re: googletagservices surrogate not working on ebay kleinanz

Post by barbaz » Mon Nov 23, 2015 5:50 pm

Fix included in 2.7rc1
*Always* check the changelogs BEFORE updating that important software!
-

Post Reply