Error on SeaMonkey startup

[barbaz]

NS 2.6.7.1rc2. The following error appears on SeaMonkey startup:

Code: Select all

Timestamp: xxxxxxxxxxxxxxxxxx
Error: TypeError: gb is null
Source File: chrome://noscript/content/noscriptOverlay.js
Line: 1481

I'm starting only the browser and using the latest SeaMonkey release (2.20) on Mac OS X. (This error doesn't happen on Linux with the same configuration.)

[Giorgio Maone]

Does NoScript work properly after that?

[barbaz]

It appears to be working fine but I wouldn't know what to look for. The file seems to suggest that I should check this by triggering the XSS filter. Could you please provide a benign "exploit" for me to test?
Edit: It's not working correctly. If I go to http :// soundcloud .com / johnerobertsjr, temp-allow soundcloud.com (a1.sndcdn.com is already whitelisted), go to the next page, listen to that track, and back with the browser's Back button, the icon shows that all scripts are allowed but to all outward appearences Javascript is completely disabled that page. Reloading the page fixed that. I don't seem to be able to reproduce this though.

In any case, that error could be circumvented by replacing getNotificationBox with something like this:

Code: Select all

  getNotificationBox: function(pos, browser) {
    // this won't get any notification for Fennec, which is good.
    
    var gb = getBrowser();
    if (gb === null || !gb.getNotificationBox) return null; // SeaMonkey, Fennec...

    browser = browser || gb.selectedBrowser;
    if (!pos) pos = this.notificationPos;

    var nb = gb.getNotificationBox(browser);
    
    if (nb) 
      this.patchNotificationBox(nb, pos);
   
    return nb;
  },

I haven't tested that code, so I have no idea if that will break something else, but feel free to use it and refine it as needed.

[barbaz]

Confirmed fixed in 2.6.8rc1. Thanks Giorgio.