FlashGot has stopped recognizing YouTube videos.

[user]

Firefox 23.0.1 wrongly identifies Flashgot 1.5.5.7rc1 as version 1.5.5.5rc2

prefs.js:
user_pref("flashgot.version", "1.5.5.5rc2");

Flashgot.log:
*** FlashGot 1.5.5.5rc2 started at 2013-09-07T05:00:04.688Z ***

Yeah, I noticed that too yesterday, when I reinstalled 1.5.5.7. That happens because the default prefs file (defaults/preferences/flashgot.js) doesn't have the "flashgot.version" preference, so it doesn't get updated when you reinstall FlashGot.

[Giorgio Maone]

That happens because the default prefs file (defaults/preferences/flashgot.js) doesn't have the "flashgot.version" preference, so it doesn't get updated when you reinstall FlashGot.

That actually happens because flashgotService.js contained a "macro", prerprocessed at build time by my ant build script, which hardcoded the version number in

Code: Select all

const VERSION = "${module.version}";

to compare it with the user's preference and decide whether an update or a first install occurred and perform any one-time task.

Merging in your already preprocessed flashgotService.js version broke this.
I'm likely gonna make this less fragile (e.g. by replacing /\bconst\s+VERSION\s*=\s*"([^"]+)"/ directly) to allow for less painful contributions.

Therefore please do NOT add a flashgot.version entry to the flashgot.js, otherwise first-installation detection would be broken.

[user]

That happens because the default prefs file (defaults/preferences/flashgot.js) doesn't have the "flashgot.version" preference, so it doesn't get updated when you reinstall FlashGot.

That actually happens because flashgotService.js contained a "macro", prerprocessed at build time by my ant build script, which hardcoded the version number in

Code: Select all

const VERSION = "${module.version}";

to compare it with the user's preference and decide whether an update or a first install occurred and perform any one-time task.

Merging in your already preprocessed flashgotService.js version broke this.
I'm likely gonna make this less fragile (e.g. by replacing /\bconst\s+VERSION\s*=\s*"([^"]+)"/ directly) to allow for less painful contributions.

Therefore please do NOT add a flashgot.version entry to the flashgot.js, otherwise first-installation detection would be broken.

Or you could just move it in a separate js file (with the comment about the file being auto-generated, etc.) and include it in wherever needed.

[Giorgio Maone]

done

[Narwhal]

I have Firefox 3.6.25 version. Updated Flashgot today. It still do not recognise youtube videos. Even RC version doesn't reconise.
May be you can give link to an older versions because they were working?

[USER]

You can get the older versions on AMO.

[Giorgio Maone]

@user:
it seems we've got a serious problem.
Couldn't check yet, but are we using GET instead of HEAD requests somewhere to fetch movie sizes or other metadata?

[user]

@user:
it seems we've got a serious problem.
Couldn't check yet, but are we using GET instead of HEAD requests somewhere to fetch movie sizes or other metadata?

If we were, you (and I, and everyone else) would be able to reproduce the problem on every page, right? So, unless the code modifies itself, we aren't. The only network related change I did was add the ch.notificationCallbacks = {...} block in MediaSniffer::peek. I unconditionally set newChannel.notificationCallbacks to us. I don't see how that can cause any problems.

[user]

The only network related change I did

No, there was another one: SWF player downloading. That's about 300 KB.

[Giorgio Maone]

The only network related change I did

No, there was another one: SWF player downloading. That's about 300 KB.

But should happen only if signature decoding fails, and just once per page even if it keeps failing (as it shouldn't).
So it must be something else...

[WhisperIII]

I'm at my wit's end with trying to identify what's causing my issue as detailed in the original post of this thread. I've tried installing FlashGot on a new Firefox profile, and it works fine on YouTube by doing this. I've tried installing every plug-in and GS script from my old profile one-by-one on the new one, and FlashGot has continued to work. I then copied my old profile folder to overwrite the new one, and sure enough, this broke FlashGot. I systematically removed all add-ons and scripts besides FlashGot after this, and it remained broken. I tried deleting my preferences file to reset them, and also reset all FlashGot preferences in about:config.

[WhisperIII]

Still, it remained broken. I am at a complete loss as to what else might be interfering with FlashGot on YouTube or where to look for it. I've been on my old profile forever and have loads of data, settings and preferences built up in the remotest corners of it, which would be a massive pain to try reinstating on a new profile.

[WhisperIII]

Otherwise, I'd just create a new profile, bring the installs up to speed, and move on. Since I have no clue what's specifically triggering the problem, though, trying to bring the lion's share of the old profile to a new one is impossible without breaking things all over again.

I guess the question I'm left with at the end of this rambling paragraph is: does anyone else have any other ideas I haven't mentioned that might feasibly be causing my specific issue with FlashGot, or where I might try trawling to see? I'm personally out of ideas. The problem is obviously not with FlashGot, but lord knows what it's with.

Sorry about the double post, both these together triggered an anti-spam message I couldn't avoid through editing.

[user]

How about enabling and examining the log or posting it here? The error console (Ctrl+Shift+J) can give some clues as well.

[loby]

void