FlashGot has stopped recognizing YouTube videos.

[WhisperIII]

This problem seemed to happen instantaneously with no outward change by me. As in, a few hours ago I was downloading YouTube videos, and after trying again just now, both the FlashGot Selection and FlashGot Media options are greyed out in the Menu bar, the typical icon doesn't appear, and none of the available options show any video file in their lists. I can go to any other site and FlashGot will register videos and work as normal. I haven't so much as closed the same browser window I had up hours ago when it was working, so it is completely beyond me what I could have triggered to cause this. Quite literally, it happened on its own. I changed no options, installed or upgraded nothing, only browsed sporadically between when it was working and when it stopped doing so. I'm kind of at a loss in terms of being thoroughly descriptive, because usually you'd have some theories along the lines of 'oh, maybe it was when I did this', 'maybe this affected the extension inadvertently', what have you, but I haven't so much as breathed at this damn computer or browser between FlashGot working and, well, not. For posterity I'm using the latest versions of both Firefox and FashGot. I've tried re-installing, reverting, restoring default settings, and checking any possibly invisible shenanigans that might've spurred a specific issue from my computer itself, but there hasn't been so much as a whisper of change in anything I could remotely think to connect to FlashGot. Plus, the mystery's still out on why it still works with any site other than YouTube.

For the record, this is across the board, so there aren't specific videos or URLs that aren't working. It's all of them.

[user]

The latest build (1.5.5.6rc1) is broken. Use 1.5.5.5rc2 or this version: http://forums.informaction.com/viewtopi ... 397#p57836

[GµårÐïåñ]

Previously discussed if you search the forum and its due to Google's recent changes to the way the videos are encrypted and the links are generated. So we are currently looking into a way to fix that. The latest development build is the most recent version containing all changes so far.

[therube]

> The latest build (1.5.5.6rc1) is broken.

That is correct.

And that is different from the issue where some of Google's content is not accessible.

[user]

Actually, don't use the version I linked - it's outdated because YouTube's changed the signature decoding algorithm.
Here's the new version:

Code: Select all

http://rghost.net/private/48388293/0de0ee1b83c5a9168f185ab742ac9730

When it'll become outdated too, just modify the string preference flashgot.media.YouTube.decode_signature_func. The only parameter that FlashGot passes to that function is an object named "params", and it has the following fields (properties):

Code: Select all

struct params
{
  // The current stream, i.e. one entry from the url_encoded_fmt_stream_map array.
  Object stream;

  // the entire video data parsed from one of these sources:
  // 1) ytplayer.config.args
  // 2) the player's flashvars attribute
  // 3) /get_vide_info output.
  Object video_info;

  // Just for convenience, the swap function from the player swf file:
  // function (arr, idx) { var tmp = arr[0]; arr[0] = arr[idx % arr.length]; arr[idx] = tmp; return arr; }
  Function swap;
}

[Giorgio Maone]

Here's the new version

Hey user, great work you made there, I'm merging it into 1.5.5.6.
Do you want to be credited with any name else than just "user"?
Thank you!

[Edit]
BTW, if you watch YT movies this, without an adblocker installed, you get an useless ASF ad as the "main" (currently playing?) movie, and all the useful stuff under the "Parsed" submenu.
Do you think is possible to work around this inconvenience, e.g. by checking that the main movie is actually listed among the parsed ones to consider it a valid entry?

[nagan]

Giorgio , just to mention your competitor Download Helper , flashes with all the available bitrates for youtube and the site you mentioned in particular.

[GµårÐïåñ]

Competitor is a big of an overreach I think. They each do what they do and they do it well, we can agree on that. But I think the intent and scope of FG has been more stable and comprehensive. Some may hack their way to making their stuff work with something but they can't reproduce that glory elsewhere unless its also been hard hacked. FG tends to be clean and consistent across the board with minimal ugly hard coded hacks to make things work. So I would say overall, FG is a much more stable solution and I say this with no bias as to my relationship with the developer, I am being sincere as a professional in my observation. JMTC.

[Giorgio Maone]

Here's the new version

Hey user, great work you made there, I'm merging it into 1.5.5.6.
Do you want to be credited with any name else than just "user"?
Thank you!

[Edit]
BTW, if you watch YT movies this, without an adblocker installed, you get an useless ASF ad as the "main" (currently playing?) movie, and all the useful stuff under the "Parsed" submenu.
Do you think is possible to work around this inconvenience, e.g. by checking that the main movie is actually listed among the parsed ones to consider it a valid entry?

@user: Don't mind, I'm figuring the customizations by myself, and hope to have the merge out in 24 hours.
I'm also doing some style normalization/cleanup work and minor integration bug fixes, so please wait for 1.5.5.6rc2 before making other changes.
Still, please let me know if you want to be credited under your real name or a different nickname.
Thank you again.

@nagan: yes, there's been a storm of further changes on Youtube's side in the meanwhile, and VDH managed to keep up earlier. It's been caught up in 1.5.5.6, due shortly (see above).

[Giorgio Maone]

Please check latest development build 1.5.5.6rc2

[WhisperIII]

I think my specific problem is divorced from the ones being brought up in this thread's replies. I installed the latest stable revision (1.5.5.6rc2), and the FlashGot Media/All are still greyed out and the icon still invisible on YouTube and YouTube alone. I don't know enough in general to isolate what could possibly be causing this for me since it seems like such a weird problem, and other people on this forum have mentioned similar ones and gotten solutions that worked for them but seem to do nothing for me. Again, it's only and invariably YouTube, with FlashGot working everywhere else it always has. I'm at a complete loss now. I could debate trying an older version and seeing if that does anything, but I'm not sure where to access those and it probably wouldn't. I swear I have no clue what's causing this.

[Giorgio Maone]

I think my specific problem is divorced from the ones being brought up in this thread's replies. I installed the latest stable revision (1.5.5.6rc2), and the FlashGot Media/All are still greyed out and the icon still invisible on YouTube and YouTube alone. I don't know enough in general to isolate what could possibly be causing this for me since it seems like such a weird problem,

Standard Diagnostic.

[user]

BTW, if you watch YT movies this, without an adblocker installed, you get an useless ASF ad as the "main" (currently playing?) movie, and all the useful stuff under the "Parsed" submenu.
Do you think is possible to work around this inconvenience, e.g. by checking that the main movie is actually listed among the parsed ones to consider it a valid entry?

It's two bugs in like 10 lines. :) Or, one bug and one WTF moment.
MediaSniffer.js, starting at line 191, MediaSniffer::observe():

Code: Select all

            contentType = contentType.replace(/;.*/); // ignore trailing extras, e.g. charset
            
            if (/\bx-ms-asf\b/.test(contentType)) {
              try {
                if (channel.contentLength && channel.contentLength < 2048) contentType = "video/x-ms-asx";
              } catch(e) {}
              try {
                if (channel.contentCharset && channel.contentLength < 16384) contentType = "video/x-ms-asx";
              } catch(e) {}
            }

First, the second argument to contentType.replace() is missing - without it, the replacement string will be "undefined" (not an undefined value, but literally the string "undefined").
Second, it's channel.contentLength in the first "if" block, but channel.contentCharset in the second one. Shouldn't both be the same? And if they should, then what's the point in the first block? :) That ASF ad gets to the media menu because it doesn't have a Content-Charset header and its Content-Length is ~9 KB, so both "if" blocks miss it and the contentType variable remains the same "video/x-ms-asf" and the ad filtering block (which was different in 1.5.5.5rc2 and tested contentType for the string "video/x-ms-asx" :p) misses it. BTW, in terms of ad skipping, I think it safe to ignore anything that comes from /(^|\.)doubleclick\.net$/, regardless of its content type or size or the presence of the "X-IMNOTANADISWEARTOGOD" header.

Currently I'm working on sandboxing the YouTube.decode_signature_func. I can post my modified Youtube.js and the defaults/preferences/flashgot.js here or wherever you prefer.

[user]

Content-Charset header

Man, don't even ask me what did I smoke before posting. But you got what I meant anyway.

[user]

BTW-2: did you forget to sign the xpi files of the 1.5.5.6 branch?