[Fixed]Attempt to fix JavaScript links - problem with spaces

Bug reports and enhancement requests
Post Reply
asdf
Posts: 2
Joined: Tue May 28, 2013 7:20 am

[Fixed]Attempt to fix JavaScript links - problem with spaces

Post by asdf »

Hello,

first of all a big thank you for the great Noscript addon!

I have enabled "Attempt to fix JavaScript links" in Options/Advanced/Untrusted and noticed that the link fix feature does not work if the link contains spaces (tested with NoScript version 2.6.6.2).
Here's one example: http://www.ikea.com/de/de/store/walldorf/offers
If I click on "Angebote vom 27.5. bis 1.6.2013" nothing happens. Since the site will probably change in the next days here's the relevant HTML source code:

Code: Select all

<a href="javascript:window.open('/ms/de_DE/img/local_store_info/walldorf/pdf_files/Flyer Tagesangebote KW 222013.pdf','800x600','scrollbars,resizable,width=800,height=600');void(0);">Angebote vom 27.5. bis 1.6.2013</a>
If the URL doesn't contain a space like on http://www.ikea.com/de/de/store/mannheim/offers

Code: Select all

<a href="javascript:window.open('/ms/de_DE/img/local_store_info/mannheim/pdf_files/2013_KW22.pdf','800x1000','toolbar,status,menubar,scrollbars,resizable,width=800,height=1000');void(0);"><br>Unsere Tagesangebote vom 27.5. bis 1.6.2013</a>
NS is able to fix the link.
Mozilla/5.0 (X11; Linux x86_64; rv:21.0) Gecko/20100101 Firefox/21.0
User avatar
Giorgio Maone
Site Admin
Posts: 9530
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: Attempt to fix JavaScript links - problem with spaces

Post by Giorgio Maone »

Investigating, thank you.
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20100101 Firefox/21.0
User avatar
Giorgio Maone
Site Admin
Posts: 9530
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: Attempt to fix JavaScript links - problem with spaces

Post by Giorgio Maone »

Please check latest development build 2.6.6.3rc1, thank you.
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20100101 Firefox/21.0
asdf
Posts: 2
Joined: Tue May 28, 2013 7:20 am

Re: Attempt to fix JavaScript links - problem with spaces

Post by asdf »

Problem solved in 2.6.6.3rc1. Many thanks for the fast fix! Keep up the great work!
Mozilla/5.0 (X11; Linux x86_64; rv:21.0) Gecko/20100101 Firefox/21.0
Post Reply