[Resolved] Flashgot fails to save files

[Marco]

Whenever I try to download something nothing happens (eg: select and right click my target then choose "Flashgot Selection" and nothing happens ... not even a popup).

Here follows the log file from a quick test:

Code: Select all

*** FlashGot 1.5.5.2 started at 2013-04-19T23:41:12.967Z ***
2013-04-19T23:41:26.207Z Preprocessing done in ms530
2013-04-19T23:41:26.214Z Starting dispatch
2013-04-19T23:41:33.950Z Dispatch done in ms7736
Total processing time: ms8273
2013-04-19T23:41:35.587Z Skipping link http://forums.informaction.com/memberlist.php?mode=viewprofile&u=2: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIFile.create]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: jar:file:///C:/Documents%20and%20Settings/Marco/Dados%20de%20aplicativos/Mozilla/Firefox/Profiles/x81qe5vb.default/extensions/%7B19503e42-ca3c-4c27-b1e2-9cdb2170ee!34%7D.xpi/components/flashgotService.js :: fg.createDownloadFile :: line 437"  data: no]

Running as administrator, but I think that "%7B19503e42-ca3c-4c27-b1e2-9cdb2170ee!34%7D.xpi" doesn't exist ...
Reinstalling doesn't work, the problem might be with the variables leftover in my profile (and I won't create a new profile).

Any help appreciated

[Marco]

I use the build-in downloader.

[therube]

("{19503e42-ca3c-4c27-b1e2-9cdb2170ee34}.xpi" is FlashGot)

Appears it is "nsIFile.create"?

So where are you trying to save the file to?
Do you have sufficient permissions for that location?

[Giorgio Maone]

So where are you trying to save the file to?
Do you have sufficient permissions for that location?

This seems right on the spot.
Notice that latest development build shows users an error message window in case the download file cannot be created, e.g. because the save location doesn't exist, is full or you've got no write permissions on it.

[Marco]

Thanks,

You're right, the path was wrong. Solved.

I'd like to make a note though:
I've downloaded the beta 1.5.5.3rc1 out of curiosity and it still doesn't show the error message properly. The message doesn't appear unless the "overwrite" option is selected.

Also, making a personal suggestion the message says:

C:\Path\image.jpg could not be saved, because an unknown error occurred.

Try saving to a different location.

I think it would be better writing this way:

The following file could not be saved:
C:\Path\image.jpg
Try saving to a different location.

because:
- this way the user is more likely to pay attention to the save part instead of unknown error which is not helpful anyway.
- the path on next line makes it easier to read
Well, that's what I think at least.

[Giorgio Maone]

Also, making a personal suggestion the message says:

C:\Path\image.jpg could not be saved, because an unknown error occurred.

Try saving to a different location.

Weird, I cannot find the string "Try saving" anywhere in FlashGot source.
Are you sure the message is from FlashGot?
Could you show me a screenshot?

[Marco]

Are you sure the message is from FlashGot?

Well, that's the only error message I got, and only when I feed an invalid path to Flashgot with the "overwrite" option marked (which I personally don't use day by day).

Could you show me a screenshot?

Yes, here it is:

[therube]

That's what I thought.
That dialog is not from FlashGot, but FF itself.

Looks like it is in, nsWebBrowserPersist.properties.

A similar bug, Bug 377196 - [fileAlreadyExistsError] '_files' directory is more confusing than necessary.