Should "Attempt to fix Javascript links" work

jmraker · Post by **jmraker** » Thu Jan 24, 2013 12:06 am

Should "Attempt to fix Javascript links" work when the firefox setting "javascript.enabled" is false (javascript is disabled)?

It appears that this NoScript setting is able to add an event handler that avoids the "javascript.enabled" is disabled setting.

An example of the fix javascript links setting working is at: http://www.eddiebauer.com/EB/Men/Polos- ... /index.cat and clicking on a shirt product link which normally submits a form in javascript.

Post by **therube** » Thu Jan 24, 2013 1:18 am

Attempt to fix JavaScript links ( enabled by default): this means that NoScript will try to turn javascript: links into normal ones on untrusted sites as you click them, improving usability of the most unfriendly pages.

http://noscript.net/features

It says that about "Untrusted" pages, which I have always taken to mean pages where JavaScript had not been allowed, rather then pages that were specifically marked as "Untrusted". And AFAICT that is the way it has always worked, on pages where JavaScript had not been allowed.

And if you manually disable JavaScript & the links still continue to function, & do not when you disable NoScript, then I'd say it was doing that too.

Post by **therube** » Thu Jan 24, 2013 1:27 am

Though I do not see where that is the case?

If eddiebauer.com is not allowed, then any attempt to "fix" the JS links does not actually work, the links do not work, you are not taken to any shirt page.

If eddiebauer.com is allowed, then you go in & manually disable javascript.enabled, then again the links do not work.

If you disable NoScript, manually disable javascript.enabled, eddiebauer.com does not work correctly.

So ... how are you doing it?

jmraker · Post by **jmraker** » Thu Jan 24, 2013 2:10 am

A simpler example

Code: Select all

<html><body>
<form id="a" method="GET" action="http://www.google.com/">
  <a onclick="a.submit();" href="javascript:void(0)">This link works in NoScript with Javascript Disabled</a>
</form>
</body></html>

NoScript is able to alter the link to submit the form when the link is clicked from a site that isn't allowed. I'm wondering If you have firefox set to have all javascript disabled is it wise to make the link submit the form as you'd expect no javascript to run even if it's fixed.

I think it would be ok to fix the link and submit the form if the browser has javascript enabled. It's questionable to do that if JS is disabled.

I could be wrong about the noscript setting fixing the link. It just seems to be the reason why the link submits the page.

Post by **therube** » Thu Jan 24, 2013 2:30 am

(Oh, you were clicking the shirt "Picture", & that does work. I was clicking the shirt "Text" & that was not working.)

Post by **therube** » Thu Jan 24, 2013 2:41 am

(Eh, I'm getting totally confused. Seemingly seeing different behaviors? Close with JS disabled, NoScript enabled. Load your "jstest.html". It seems that it fails, google is not loaded. Mess around some, new window perhaps. Load jstest.html. Try. Another window, load an actual site, then try jstest.html. Maybe it does then work? Or something? And I thought I ran across something where NoScript was defaulting javascript.enabled to be true? Or maybe that was only on install of NoScript? ZZZzzz.)

[It was this I was thinking of, Allow Scripts Globally Enables JavaScript]

jmraker · Post by **jmraker** » Thu Jan 24, 2013 5:50 pm

I made a screencast of what I'm seeing at http://www.screencast.com/t/IBW2JfpFh

The video starts off with javascript disabled and "Fix Javascript Links" off
. I open the firefox options to show javascript is turned off
. Reload the page
. Click on the link, it does not work
. Open the NoScript options, turn on "Attempt to fix javascript links"
. Reload the page
. Click on the link, it does work and doesn't ignore what is in the onclick="a.submit();" in the link
. I open the firefox options to show that javascript is still turned off

I'm not sure which setting is creating the submit button that's added. The button goes away when the site is allowed.

Should the "Attempt to fix javascript links" work this way?

InformAction Forums

Should "Attempt to fix Javascript links" work

Should "Attempt to fix Javascript links" work

Re: Should "Attempt to fix Javascript links" work

Re: Should "Attempt to fix Javascript links" work

Re: Should "Attempt to fix Javascript links" work

Re: Should "Attempt to fix Javascript links" work

Re: Should "Attempt to fix Javascript links" work

Re: Should "Attempt to fix Javascript links" work