[RESOLVED] About the new click-and-delete feature in v2.5.1

Ask for help about NoScript, no registration needed to post
mjh563

[RESOLVED] About the new click-and-delete feature in v2.5.1

Post by mjh563 »

Hi, I'm intrigued by this new feature in 2.5.1, but should it remove only non-static content, or any content?
+ Holding the left mouse button down on an absolutely positioned page
element and hitting the DEL key will remove it (useful to forcibly kill
in-page popups when scripts are disabled)
It currently removes the element that you click on, regardless of its position type. I think this line is incorrect (noscriptOverlay.js:2529):

Code: Select all

if (w.getComputedStyle(el, '') !== "static") {
Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20100101 Firefox/15.0
User avatar
GµårÐïåñ
Lieutenant Colonel
Posts: 3377
Joined: Fri Mar 20, 2009 5:19 am
Location: PST - USA
Contact:

Re: About the new click-and-delete feature in v2.5.1

Post by GµårÐïåñ »

I have not evaluated the full code but I believe since it is removing a static content only, it should be fine. I am sure Giorgio will take a look and see.
~.:[ Lï£ê ï§ å Lêmðñ åñÐ Ì Wåñ† M¥ Mðñê¥ ßå¢k ]:.~
________________ .: [ Major Mike's ] :. ________________
Mozilla/5.0 (Windows NT 6.1; rv:14.0) Gecko/20100101 Firefox/14.0.1
mjh563

Re: About the new click-and-delete feature in v2.5.1

Post by mjh563 »

Oh, it looks as though this has already been fixed in 2.5.2rc1. :)
Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20100101 Firefox/15.0
User avatar
therube
Ambassador
Posts: 7991
Joined: Thu Mar 19, 2009 4:17 pm
Location: Maryland USA

Re: About the new click-and-delete feature in v2.5.1

Post by therube »

Nuke Anything Enhanced (or maybe this for SeaMonkey users, nuke_anything_enhanced-1.0.2-mod.xpi).
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.19) Gecko/20110420 SeaMonkey/2.0.14 Pinball NoScript FlashGot AdblockPlus
Mozilla/5.0 (Windows NT 5.1; rv:16.0) Gecko/20120820 Firefox/16.0 SeaMonkey/2.13a2
User avatar
GµårÐïåñ
Lieutenant Colonel
Posts: 3377
Joined: Fri Mar 20, 2009 5:19 am
Location: PST - USA
Contact:

Re: About the new click-and-delete feature in v2.5.1

Post by GµårÐïåñ »

mjh563 wrote:Oh, it looks as though this has already been fixed in 2.5.2rc1. :)
Yes it has.
~.:[ Lï£ê ï§ å Lêmðñ åñÐ Ì Wåñ† M¥ Mðñê¥ ßå¢k ]:.~
________________ .: [ Major Mike's ] :. ________________
Mozilla/5.0 (Windows NT 6.1; rv:14.0) Gecko/20100101 Firefox/14.0.1
Post Reply