[Resolved] NoScript 2.2.9 seems to break sites' CSS

[azrael]

I noticed that some web pages looked weird today. The first one to catch my eyes was IMDB, where the search box at the top was way too small for the font. I thought I had accidentally messed with some font settings (size mostly) or had accidentally enabled page zoom, so I tried rectifying that, but to no avail. Later I was visiting http://recordere.dk, another site I frequent daily, and was wondering if they too had done something to their layout. Then the forums of Bit-Tech (http://forums.bit-tech.net). That site also looked off.

Then I recalled that I had allowed NoScript 2.2.9rc2 to be installed last night. I disabled NoScript and voila! the problems were gone. I then installed v2.2.9 from the download link (http://noscript.net/getit) and the issues returned (is v2.2.9rc2 supposed to be newer than v2.2.9?). Rolling back to v2.2.8 solved the issues, though.

I'm not quite sure exactly what goes wrong, but at a glance it seems that something happens to the style sheets sites are loading.

[Mc]

Confirmed?
Today a site was built correctly, but after a second most of the style (site formatting, background) was stripped. I didn't think of the NoScript update in that moment, though. I'll try to reproduce it, but don't remember the site

[Alan Baxter]

(is v2.2.9rc2 supposed to be newer than v2.2.9?)

They are the same.

[Alan Baxter]

@azrael:
I'm unable to reproduce your problem on any of the three sites you mention.
NoScript 2.2.9rc2 with default settings, except the top level site was allowed in each case.
Fx 10.0, default theme, no other extensions
Windows XP SP3

Edit: Are you really using Firefox 3.0.19?
Edit: I'm able to reproduce the problem in Fx 3.0.19, but not in Fx 10.0

[Ix]

I think it's a problem with Firefox 3. I'm using it too and NoScript 2.2.9rc2 is causing all sorts of display issues: font sizes are increased/decreased, margins/padding is off, etc.

[azrael]

@azrael:
I'm unable to reproduce your problem on any of the three sites you mention.
NoScript 2.2.9rc2 with default settings, except the top level site was allowed in each case.
Fx 10.0, default theme, no other extensions
Windows XP SP3

Edit: Are you really using Firefox 3.0.19?
Edit: I'm able to reproduce the problem in Fx 3.0.19, but not in Fx 10.0

I thought I'd better register so now I'm able to complain "officially"...

Yes, you are correct in that I'm (still) using FF 3.0.19. Never really took to 3.6 and I've got some rendering issues since FF4, which, although reported (by me) and confirmed (by others), still haven't been fixed in FF10.

I should have mentioned which browser I'm using in my original post. Sorry for this.

I can add that I'm still on Windows XP, which you've probably also know. As for themes I'm using the original Silver XP theme that comes with Windows XP, although I've changed the titlebar font and am using a background image. Neither of which I believe should pose any issues with NoScript.

[therube]

Does it happen with all other extensions disabled except for NoScript?

How about some with/without screenshots?

Not seeing (at least noticing) anything out of place at recordere in 3.0, 3.5, or 3.6.

[Alan Baxter]

Not seeing (at least noticing) anything out of place at recordere in 3.0, 3.5, or 3.6.

Look more closely using Fx 3.0.19 with NoScript 2.2.9rc2 with default settings, except allowing the top level site. Look at the text for each article in the summaries down the middle of the page. The font is bigger in each summary if NoScript is installed.

I haven't attempted to reproduce the problem in 3.5 or 3.6. Should be easy enough for Giorgio to do when he investigates.

[therube]

OK, those little details help.
Block, Allowed; FF 3.0, SeaMonkey 2.9

[Giorgio Maone]

Please check latest development build 2.3rc1

[azrael]

Just installed 2.3rc1 and from what I can see it certainly seems to fix the CSS issues I've experienced. Great job fixing this! And so quickly.

Might I inquire what turned out to be the problem? Just in broad terms. Oh, and once more, sorry for posting such a relatively lousy bug report. I should know better. I'm usually at the receiving end...

[Giorgio Maone]

Might I inquire what turned out to be the problem? Just in broad terms.

The fix for the Script Surrogates incompatibility with CSP regressed away a work-around previously introduced for the same problem you reported: Firefox 3.0 doesn't play well with scripts executed very early in the document building process through DOM manipulation, and causes various CSS inconsistencies. This had been worked around by using Components.utils.Sandbox instead in order to run surrogates and other document-patching early scripts, but 2.2.9 accidentally turned back on the old DOM-based codepath for older browser versions.

[azrael]

Thanks a lot for the explanation.