SyntaxChecker sandbox needs JS_VERSION

[al_9x]

Code: Select all

return Cu.evalInSandbox(s, this.sandbox);

[Giorgio Maone]

Yes it does...

[al_9x]

NS 2.2.4rc2

1. ScriptSurrogate.js:9 - JS_VERSION is unqualified
2. with the above fixed, surrogates still don't seem to be running at all with ECMAv5, "1.8" works.
3. ScriptSurrogate.js:99 - would be helpful for syntax error log to mention the source ("Error parsing {name} surrogate: {error}")

[al_9x]

with the above fixed, surrogates still don't seem to be running at all with ECMAv5

with ECMAv5, @* surrogate runs for frames but not top level windows

[Giorgio Maone]

Does 1.85 work?

[al_9x]

Does 1.85 work?

No, only "1.8." Did you find that 1.8 was inadequate, how?

[Giorgio Maone]

Does 1.85 work?

No, only "1.8." Did you find that 1.8 was inadequate, how?

Looking at the Mozilla source code, I found the highest supported version has an identifier string of "1.85", while "ECMAv5" is a sort of alias for "latest version".
I was hoping to make Surrogate more future proof by using either, but I guess I need to settle with 1.8.

On a side note, I strongly suspect this problem affects only users (like you) who have noscript.surrogate.sandbox set to false (i.e. those are not valid version identifiers for the <script> element).

[al_9x]

On a side note, I strongly suspect this problem affects only users (like you) who have noscript.surrogate.sandbox set to false (i.e. those are not valid version identifiers for the <script> element).

I have sandbox=true in my main profile and besides always confirm in a clean profile, however I don't think sandbox matters here. This is the clause that affects @ surrogates (right?), for top level windows it chooses this.execute, regardless of sandbox.

Code: Select all

scriptURL === pageURL ? let (win = document.defaultView) win != win.top ? this.executeSandbox : this.execute

[Giorgio Maone]

OK, restored 1.8 in latest development build 2.2.4rc3.