"(Temporarily) Allow all on this page" access keys

Bug reports and enhancement requests
Mike A.
Posts: 13
Joined: Wed Jul 29, 2009 1:49 pm

"(Temporarily) Allow all on this page" access keys

Post by Mike A. »

I am confused as to why the the "(Temporarily) Allow all on this page" access keys are problematic and were removed with v 2.1.3rc4. I see the following posts on this topic.

Problematic Hotkeys while NoScript menu is popped up

NoScript vulnerability: ctrl-T inadvertently allows sites!

This is one of the most heavily used features of NoScript for me and I imagine many others because very few sites are whitelisted. On almost any site I will use ctrl+shift+\ or ctrl+shift+s t and temporarily allow scripts.

Why is is problematic to temporarily allow all with hotkey access?

It seems that the problem of "inadvertently" pressing t while the UI is open is similar to saying Firefox crashes because of "inadvertently" pressing x while the File menu is open.

It would be nice to bring back this highly used functionality with some sort of compromise instead of removing it completely. Please consider either of the following options.

Add a boolean preference in about:config for noscript.accessKeys that would default to false but would allow adding back this functionality.

Add a noscript.keys.toggleAll preference in about:config for defining a "(Temporarily) Allow all on this page" shortcut.

Thanks for your consideration of either of the above requests!
Mozilla/5.0 (Windows NT 6.1; rv:7.0.1) Gecko/20100101 Firefox/7.0.1
User avatar
Giorgio Maone
Site Admin
Posts: 9524
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: "(Temporarily) Allow all on this page" access keys

Post by Giorgio Maone »

The issue is not about the shortcut you mentioned, but about the "T" menu accelerator (Temporarily allow all this page) which has already been removed.
Mozilla/5.0 (Windows NT 5.2; WOW64; rv:7.0.1) Gecko/20100101 Firefox/7.0.1
Mike A.
Posts: 13
Joined: Wed Jul 29, 2009 1:49 pm

Re: "(Temporarily) Allow all on this page" access keys

Post by Mike A. »

Giorgio, you are correct, "menu accelerator" or "access keys". This is the issue I am referring to. "ctrl+shift+s t and temporarily allow scripts" was removed. Now we cannot temporarily allow all with the keyboard, why was this removed?
Mike A. wrote:Add a boolean preference in about:config for noscript.accessKeys that would default to false but would allow adding back this functionality.
Change this to "noscript.menuAccelerator"

A possible third option would be to add a boolean preference in about:config for noscript.toggle.all that would default to false but would allow the ctrl+shift+\ hotkey to be used for this functionality.

Thanks for your consideration!
Mozilla/5.0 (Windows NT 6.1; rv:7.0.1) Gecko/20100101 Firefox/7.0.1
Mike A.
Posts: 13
Joined: Wed Jul 29, 2009 1:49 pm

Re: "(Temporarily) Allow all on this page" access keys

Post by Mike A. »

Can this issue be fixed? Have I explained the problem clearly enough?
From the NoScript CHANGELOG wrote:v 2.1.3rc4
==========================================================================
x Removed problematic "(Temporarily) Allow all on this page" access keys
This change created a problem with using the keyboard to temporarily allow all on this page. Now the keyboard cannot be used becuase the "T" menu accelerator is gone.

Can there be an option to add back this functionality?

Thanks!
Mozilla/5.0 (Windows NT 6.1; rv:7.0.1) Gecko/20100101 Firefox/7.0.1
Yxp
Posts: 8
Joined: Mon Dec 28, 2009 2:39 pm

Re: "(Temporarily) Allow all on this page" access keys

Post by Yxp »

I'd like to point out that ctrl-shit-backslash is a bit problematic for finnish (and probably other too) users since for us backslash requires a key combination (alt gr-+)
Mozilla/5.0 (Windows NT 6.1; rv:7.0.1) Gecko/20100101 Firefox/7.0.1
Mike A.
Posts: 13
Joined: Wed Jul 29, 2009 1:49 pm

Re: "(Temporarily) Allow all on this page" access keys

Post by Mike A. »

Yxp wrote:I'd like to point out that ctrl-shit-backslash is a bit problematic for finnish (and probably other too) users since for us backslash requires a key combination (alt gr-+)
See the 3.11 FAQ. "You can easily reconfigure NoScript's keyboard shortcuts by editing the noscript.keys.* preferences in about:config."
Mozilla/5.0 (Windows NT 6.1; rv:7.0.1) Gecko/20100101 Firefox/7.0.1
Yxp
Posts: 8
Joined: Mon Dec 28, 2009 2:39 pm

Re: "(Temporarily) Allow all on this page" access keys

Post by Yxp »

Mike A. wrote:
Yxp wrote:I'd like to point out that ctrl-shit-backslash is a bit problematic for finnish (and probably other too) users since for us backslash requires a key combination (alt gr-+)
See the 3.11 FAQ. "You can easily reconfigure NoScript's keyboard shortcuts by editing the noscript.keys.* preferences in about:config."
I had no idea :oops: Thanks!
Mozilla/5.0 (Windows NT 6.1; rv:7.0.1) Gecko/20100101 Firefox/7.0.1
Mike A.
Posts: 13
Joined: Wed Jul 29, 2009 1:49 pm

Re: "(Temporarily) Allow all on this page" access keys

Post by Mike A. »

Can anyone comment on the option to best resolve this issue?

New preferences editable in about:config.
  1. noscript.menuAccelerator - boolean defaults to false
    If true, menu accelerators are displayed, i.e. "T" (Temporarily allow all this page)
  2. noscript.keys.toggleAll - string defaults to blank
    Simlar to noscript.keys.toggle, allows the ability to configure a keyboard shortcut for Temporarily Allow all on this page
  3. noscript.toggle.all - boolean defaults to false
    Simlar to noscript.toggle.temp, if true, changes CTRL + SHIFT + \ (backslash) to toggle allowance status for every site shown instead of current top-level domain
I hope for the implementation of enhancement #2 at some point and this has been requested before.
Mozilla/5.0 (Windows NT 6.1; rv:7.0.1) Gecko/20100101 Firefox/7.0.1
User avatar
Giorgio Maone
Site Admin
Posts: 9524
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: "(Temporarily) Allow all on this page" access keys

Post by Giorgio Maone »

Thank you for your proposal, I'm putting #1 and #3 in my TODO list.
Mozilla/5.0 (Windows NT 5.2; WOW64; rv:7.0.1) Gecko/20100101 Firefox/7.0.1
Mike A.
Posts: 13
Joined: Wed Jul 29, 2009 1:49 pm

Re: "(Temporarily) Allow all on this page" access keys

Post by Mike A. »

Thanks for the support! Cheers!
Mozilla/5.0 (Windows NT 6.1; rv:7.0.1) Gecko/20100101 Firefox/7.0.1
Alan Baxter
Ambassador
Posts: 1586
Joined: Fri Mar 20, 2009 4:47 am
Location: Colorado, USA

Re: "(Temporarily) Allow all on this page" access keys

Post by Alan Baxter »

Good going, Mike. Thank you for your persistence.
Mozilla/5.0 (Windows NT 5.1; rv:7.0.1) Gecko/20100101 Firefox/7.0.1
User avatar
Giorgio Maone
Site Admin
Posts: 9524
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: "(Temporarily) Allow all on this page" access keys

Post by Giorgio Maone »

Mozilla/5.0 (Windows NT 5.2; WOW64; rv:7.0.1) Gecko/20100101 Firefox/7.0.1
taka
Posts: 3
Joined: Mon Oct 24, 2011 3:50 am

Re: "(Temporarily) Allow all on this page" access keys

Post by taka »

I found a bug(NoScript 2.1.7).
When a "(Temporarily) Allow all on this page" access key is set up, It becomes impossible to input the key in Firefox.
Mozilla/5.0 (Windows NT 6.1; rv:7.0.1) Gecko/20111023 Firefox/7.0.1
User avatar
Giorgio Maone
Site Admin
Posts: 9524
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: "(Temporarily) Allow all on this page" access keys

Post by Giorgio Maone »

taka wrote:I found a bug(NoScript 2.1.7).
When a "(Temporarily) Allow all on this page" access key is set up, It becomes impossible to input the key in Firefox.
Could you be more detailed?
How do the relevant preferences look like, exactly?
Mozilla/5.0 (Windows NT 5.2; WOW64; rv:7.0.1) Gecko/20100101 Firefox/7.0.1
taka
Posts: 3
Joined: Mon Oct 24, 2011 3:50 am

Re: "(Temporarily) Allow all on this page" access keys

Post by taka »

I am using machine translation.
I am sorry to be unable to explain well.

For example
about:config noscript.keys.tempAllowPage=P

When setting up in this way, It becomes impossible to input the P key in all in Firefox, such as location bar, search bar, and web page.

Of course, this bug happens not only by the P key but by all the keys.
Is it a bug which happens only in my environment?
Mozilla/5.0 (Windows NT 6.1; rv:7.0.1) Gecko/20111023 Firefox/7.0.1
Post Reply