refresh in ABE options makes rulesets disappear

Bug reports and enhancement requests
Post Reply
al_9x
Master Bug Buster
Posts: 931
Joined: Thu Mar 19, 2009 4:52 pm

refresh in ABE options makes rulesets disappear

Post by al_9x »

NS 2.1.0.1, Fx 3.6.16, new profile
  1. open abe options
  2. select USER
  3. click refresh, then ok
  4. reopen abe options, the rulesets listbox is empty
  5. PS 1: NS options will close with an ABE syntax error, that had not been highlighted, prior to clicking ok. I think this was addressed once.
  6. PS 2: I think that for a large set of rules, file based storage is more user friendly than a huge pref string, and possibly more reliable
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.16) Gecko/20110319 Firefox/3.6.16
al_9x
Master Bug Buster
Posts: 931
Joined: Thu Mar 19, 2009 4:52 pm

Re: refresh in ABE options makes rulesets disappear

Post by al_9x »

I was clicking refresh just to force a syntax check, what is it actually for?
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.16) Gecko/20110319 Firefox/3.6.16
User avatar
Giorgio Maone
Site Admin
Posts: 9527
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: refresh in ABE options makes rulesets disappear

Post by Giorgio Maone »

Fixed in latest development build 2.1.0.2rc1.
al_9x wrote: # PS 1: NS options will close with an ABE syntax error, that had not been highlighted, prior to clicking ok. I think this was addressed once.
Not sure I understand, could you elaborate?
al_9x wrote: # PS 2: I think that for a large set of rules, file based storage is more user friendly than a huge pref string, and possibly more reliable
User friendly maybe, even though you can always copy from the textarea, edit wherever you want and paste back.
More reliable I doubt, and anyway all the other settings are there in preferences.
Surely heavier on startup performance, due to the additional I/O, and a pain to keep in sync without native file change notifications.
al_9x wrote: I was clicking refresh just to force a syntax check, what is it actually for?
It clears the cache of remote site rulesets, so when you visit them again they're refreshed.
It used also to reload the local ruleset files, but it doesn't affect local rulesets anymore because they're refreshed in real time thanks to pref changes notifications.
Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9.2.16) Gecko/20110319 Firefox/3.6.16
al_9x
Master Bug Buster
Posts: 931
Joined: Thu Mar 19, 2009 4:52 pm

Re: refresh in ABE options makes rulesets disappear

Post by al_9x »

Giorgio Maone wrote:
al_9x wrote: # PS 1: NS options will close with an ABE syntax error, that had not been highlighted, prior to clicking ok. I think this was addressed once.
Not sure I understand, could you elaborate?
If you introduce a syntax error into an ABE ruleset and then when done editing, click ok to close the dialog, it closes, saving the error. The error highlight only briefly flashes, prior to closing, that's not an adequate notification. It should alert you about the error and stay open.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.16) Gecko/20110319 Firefox/3.6.16
al_9x
Master Bug Buster
Posts: 931
Joined: Thu Mar 19, 2009 4:52 pm

Re: refresh in ABE options makes rulesets disappear

Post by al_9x »

Giorgio Maone wrote:More reliable I doubt
here's what i had in mind: when the rulsets disappeared, I went into about:config to check the abe prefs and remove my latest changes (thinking they were the cause). Modifying the pref via about:config stripped all the new lines, necessitating a manual reconstruction. All this just gave me an impression of flakiness of the new storage.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.16) Gecko/20110319 Firefox/3.6.16
dhouwn
Bug Buster
Posts: 968
Joined: Thu Mar 19, 2009 12:51 pm

Re: refresh in ABE options makes rulesets disappear

Post by dhouwn »

al_9x wrote:Modifying the pref via about:config stripped all the new lines, necessitating a manual reconstruction.
This is an about:config issue then: https://bugzilla.mozilla.org/show_bug.cgi?id=358984 /edit: Oops, that's not an UI bug report.
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0) Gecko/20100101 Firefox/4.0
User avatar
Giorgio Maone
Site Admin
Posts: 9527
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: refresh in ABE options makes rulesets disappear

Post by Giorgio Maone »

al_9x wrote:It should alert you about the error and stay open.
I agree. Will be done before next release.
Mozilla/5.0 (Windows NT 5.2; WOW64; rv:2.0) Gecko/20100101 Firefox/4.0
User avatar
Giorgio Maone
Site Admin
Posts: 9527
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: refresh in ABE options makes rulesets disappear

Post by Giorgio Maone »

Giorgio Maone wrote:
al_9x wrote:It should alert you about the error and stay open.
I agree. Will be done before next release.
Done in latest development build.
Mozilla/5.0 (Windows NT 5.2; WOW64; rv:2.0) Gecko/20100101 Firefox/4.0
Post Reply