2.0rc8 introduced some placeholder and icon issues

Bug reports and enhancement requests
User avatar
Giorgio Maone
Site Admin
Posts: 9527
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: 2.0rc8 introduced some placeholder and icon issues

Post by Giorgio Maone »

Sorry, nothing to do about it.
The placeholder creation needs to be deferred because DOM manipulation can't happen immediately due to architecture limitations.
Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9.2.12) Gecko/20101026 Firefox/3.6.12
al_9x
Master Bug Buster
Posts: 931
Joined: Thu Mar 19, 2009 4:52 pm

Re: 2.0rc8 introduced some placeholder and icon issues

Post by al_9x »

Giorgio Maone wrote:Sorry, nothing to do about it.
The placeholder creation needs to be deferred because DOM manipulation can't happen immediately due to architecture limitations.
Placeholder creation was deferred in 2.0rc7 also, I am not suggesting it shouldn't be, the issue is how much. Are you not seeing the difference on the simple page above? In 2.0rc7 it's so quick, it's invisible. In 2.0.6rc1 it's longer, producing this flashing effect. Is there a reason it had to get longer? Are you not in control of this timing?
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.12) Gecko/20101026 Firefox/3.6.12
User avatar
Giorgio Maone
Site Admin
Posts: 9527
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: 2.0rc8 introduced some placeholder and icon issues

Post by Giorgio Maone »

Recent NoScript versions coalesce placeholder replacements with about a 400ms resolutions, which greatly improve overall page loading times.
I don't want to touch this rather complicated stuff for a cosmetic change, while it will likely undergo a major rewrite for e10s.
Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9.2.12) Gecko/20101026 Firefox/3.6.12
al_9x
Master Bug Buster
Posts: 931
Joined: Thu Mar 19, 2009 4:52 pm

Re: 2.0rc8 introduced some placeholder and icon issues

Post by al_9x »

Giorgio Maone wrote:Recent NoScript versions coalesce placeholder replacements with about a 400ms resolutions
Does it make sense for this to be configurable? Or does the current code rely on a specific value? If possible, I would experiment with something lower.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.12) Gecko/20101026 Firefox/3.6.12
User avatar
Giorgio Maone
Site Admin
Posts: 9527
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: 2.0rc8 introduced some placeholder and icon issues

Post by Giorgio Maone »

It's hard-coded. Look inside noscriptOverlay.syncUI().
Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9.2.12) Gecko/20101026 Firefox/3.6.12
al_9x
Master Bug Buster
Posts: 931
Joined: Thu Mar 19, 2009 4:52 pm

Re: 2.0rc8 introduced some placeholder and icon issues

Post by al_9x »

Giorgio Maone wrote:It's hard-coded. Look inside noscriptOverlay.syncUI().
Can you make it configurable?
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.12) Gecko/20101026 Firefox/3.6.12
Post Reply