RFE: add "force https for $currentsite" to NoScript menu

Bug reports and enhancement requests
Post Reply
dkg
Posts: 5
Joined: Thu Jan 14, 2010 6:26 pm

RFE: add "force https for $currentsite" to NoScript menu

Post by dkg »

Hi good NoScript people!

One of the things i've been using NoScript more for recently is to list sites that should only be used over HTTPS.

(this is under Advanced|HTTPS|Behavior in the options dialog box)

It would be nice to have an option in the menu that makes it easy and quick to add a domain to the list of sites which NoScript enforces like this.

One suggestion would be a menu option that says "force https for foo.example.com" when the user is visiting https://foo.example.com/

Any takers? Would it be useful if i provided a patch?
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.6) Gecko/20091216 Iceweasel/3.5.6 (like Firefox/3.5.6; Debian-3.5.6-1)
User avatar
Giorgio Maone
Site Admin
Posts: 9524
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: RFE: add "force https for $currentsite" to NoScript menu

Post by Giorgio Maone »

It doesn't seem to me a routine task, worth adding a new item to an already crowded menu.
Thanks for your suggestion and your will to contribute, though :)
Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9.1.7) Gecko/20091221 Firefox/3.5.7 (.NET CLR 3.5.30729)
dkg
Posts: 5
Joined: Thu Jan 14, 2010 6:26 pm

Re: RFE: add "force https for $currentsite" to NoScript menu

Post by dkg »

Well, it's not a routine task for me because it's so inconvenient to do. I'd like to start making it a routine task, though, as i'd like to see more of my web traffic be encrypted by default.

how about a patch which adds another checkbox to the "Contextual menu" config (in the Appearance tab in the Options dialog) to enable this entry in the menu? would you consider adopting something like that in a future version? I'd be fine with it being unchecked by default; i totally understand the concern about unwanted UI clutter.

(note: i don't have such a patch written yet, but i'm confident in my ability to generate one if you'd be willing to accept it upstream)
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.6) Gecko/20091216 Iceweasel/3.5.6 (like Firefox/3.5.6; Debian-3.5.6-1)
User avatar
Giorgio Maone
Site Admin
Posts: 9524
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: RFE: add "force https for $currentsite" to NoScript menu

Post by Giorgio Maone »

@dkg:
OK, I'm putting it in my TODO list.
Feel free to send me a patch by email, but be warned: it might be more complex than you think, including localization and two UIs: you'll finish to touch at least 3 files and need to examine at least 5.
Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9.1.7) Gecko/20091221 Firefox/3.5.7 (.NET CLR 3.5.30729)
dkg
Posts: 5
Joined: Thu Jan 14, 2010 6:26 pm

Re: RFE: add "force https for $currentsite" to NoScript menu

Post by dkg »

Thanks, Giorgio! I'll have a look at it this weekend or next week to see what it'll take.
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.6) Gecko/20091216 Iceweasel/3.5.6 (like Firefox/3.5.6; Debian-3.5.6-1)
dkg
Posts: 5
Joined: Thu Jan 14, 2010 6:26 pm

Re: RFE: add "force https for $currentsite" to NoScript menu

Post by dkg »

do you have a preferred revision control system for me to work from? or should i just base the patch of the latest development build?
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.6) Gecko/20091216 Iceweasel/3.5.6 (like Firefox/3.5.6; Debian-3.5.6-1)
User avatar
Giorgio Maone
Site Admin
Posts: 9524
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: RFE: add "force https for $currentsite" to NoScript menu

Post by Giorgio Maone »

dkg wrote:should i just base the patch of the latest development build?
That's fine.
Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9.1.7) Gecko/20091221 Firefox/3.5.7 (.NET CLR 3.5.30729)
dkg
Posts: 5
Joined: Thu Jan 14, 2010 6:26 pm

Re: RFE: add "force https for $currentsite" to NoScript menu

Post by dkg »

ok, i'll try to do that. i prefer to work from a revision control system if one's available, but i don't mind working from tarballs.
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.6) Gecko/20091216 Iceweasel/3.5.6 (like Firefox/3.5.6; Debian-3.5.6-1)
Post Reply