[fixed] 13.4.912: STRICT / EASIER / EASIEST

[fatboy]

How should "Site Classification Behavior" work?

Options > General. Click on the “STRICT / Default Deny” button.
Select “EASIEST / Default allow” (or “EASIER / Auto”), click on the cross.
The button still displays “STRICT / Default Deny.”
I click on the button again and see that “EASIEST / Default allow” is selected.
I open https://maone.net/ (not available in Per-site Permissions) — DEFAULT.

If I close and reopen Settings, the “STRICT / Default Deny” radio button is selected.

Maybe it's because of a non-standard Firefox?

Windows 7, Fx (e3kskoy7wqk) 140.5.0esr, NS 13.4.912, clean profile, default settings.

When opening the Settings page:

Code: Select all

NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIFaviconService.setFaviconForPage]
    setIconFromLink resource:///actors/LinkHandlerParent.sys.mjs:142
    receiveMessage resource:///actors/LinkHandlerParent.sys.mjs:55
LinkHandlerParent.sys.mjs:151:17
    setIconFromLink resource:///actors/LinkHandlerParent.sys.mjs:151
    receiveMessage resource:///actors/LinkHandlerParent.sys.mjs:55

After a few seconds:

Code: Select all

TypeError: this._getHandlerAppItem is not a function WindowsJumpLists.sys.mjs:391:23

No errors when changing the radio button.

[Giorgio Maone]

Probably the bug I've just fixed in 13.4.914 (missing UI synchronization step).

[fatboy]

13.4.914

Created a new profile.
When installing NS:

Code: Select all

TypeError: can't access property "results", queryContext is undefined
    onSearchSessionEnd resource:///modules/UrlbarProviderGlobalActions.sys.mjs:150
    tryMethod resource:///modules/UrlbarUtils.sys.mjs:2622
    #notifySearchSessionEnd resource:///modules/UrlbarProvidersManager.sys.mjs:492
    notifyEngagementChange resource:///modules/UrlbarProvidersManager.sys.mjs:429
    #internalRecord resource:///modules/UrlbarController.sys.mjs:977
    record resource:///modules/UrlbarController.sys.mjs:879
    handleNavigation resource:///modules/UrlbarInput.sys.mjs:859
    handleCommand resource:///modules/UrlbarInput.sys.mjs:698
    _initPasteAndGo resource:///modules/UrlbarInput.sys.mjs:3663
UrlbarUtils.sys.mjs:2624:15

When opening Settings:

Code: Select all

TypeError: can't access property "ownerGlobal", browser is null BrowserElementParent.sys.mjs:21:21
    receiveMessage resource://gre/actors/BrowserElementParent.sys.mjs:21
    
    Error: Missing host permission for the tab [NoScript] Could not run scripts on %s: privileged page? about:home @moz-extension://7c7f8afb-9c39-4b62-aad9-637a830738bc/ui/popup.js:288:14
async*@moz-extension://7c7f8afb-9c39-4b62-aad9-637a830738bc/ui/popup.js:479:3
log.js:44:15
sendRemoveListener on closed conduit {73a6fe31-595d-460b-a920-fcc0f8843232}.549755814538 ConduitsChild.sys.mjs:122:13

a little later:

Code: Select all

Uncaught TypeError: can't access property "addEventListener", document.querySelector(...) is null
    <anonymous> moz-extension://7c7f8afb-9c39-4b62-aad9-637a830738bc/ui/behavior.js:93
    <anonymous> moz-extension://7c7f8afb-9c39-4b62-aad9-637a830738bc/ui/behavior.js:125
behavior.js:93:12

Nothing else has changed. Probably we need to wait for someone to check on Windows 10, Fx 140esr

UPD: When installing on a clean profile, "Welcome to NoScript" is not displayed.

[Giorgio Maone]

13.4.914

Code: Select all

Uncaught TypeError: can't access property "addEventListener", document.querySelector(...) is null
    <anonymous> moz-extension://7c7f8afb-9c39-4b62-aad9-637a830738bc/ui/behavior.js:93
    <anonymous> moz-extension://7c7f8afb-9c39-4b62-aad9-637a830738bc/ui/behavior.js:125
behavior.js:93:12

Nothing else has changed. Probably we need to wait for someone to check on Windows 10, Fx 140esr

UPD: When installing on a clean profile, "Welcome to NoScript" is not displayed.

Could you please check whether this messages are still present in 915?
The other ones are most likely not related to NoScript specifically.

UPD: When installing on a clean profile, "Welcome to NoScript" is not displayed.

This is expected, as the actual onboarding startup hooks still need to be implemented (hopefully in 916).

[fatboy]

13.4.915
No, these messages are not being repeated.
There is no change in behavior.

[Giorgio Maone]

Please check 916, thank you (no startup hooks yet for onboarding, but I should have tentatively fixed a potential race condition which might have been the root cause of the inconsistencies you've noticed).

[fatboy]

13.4.916
Now the selected “behavior” is displayed on the button.
However, if you select “EASIER” or “EASIEST” and open any ‘unclassified’ site, “DEFAULT” will be applied to it and its subdocuments.
There is no mention of behavior.js in the console.

[Giorgio Maone]

Thank you for testing, please check 917

[fatboy]

13.4.917
Thank you. Now it works as expected.
When installing NS:

Code: Select all

FrameData missing for {73a6fe31-595d-460b-a920-fcc0f8843232} page moz-extension://413e608e-4e2d-4e11-8d62-c76d7b41caeb/ui/popup.html ExtensionPageChild.sys.mjs:459
    initExtensionContext resource://gre/modules/ExtensionPageChild.sys.mjs:459
    initExtensionDocument resource://gre/modules/ExtensionProcessScript.sys.mjs:390

[Giorgio Maone]

13.4.918 has the onboarding hooks.