NoScript 11.4.40 crashed Tor Browser with Selenium

Bug reports and enhancement requests
Post Reply
Brian Cohen
Posts: 3
Joined: Mon Sep 30, 2024 11:26 am

NoScript 11.4.40 crashed Tor Browser with Selenium

Post by Brian Cohen »

I maintain a downstream Selenium-driven Tor Browser [project](https://gitlab.com/matzfan/selenium-tor) and in my tests for TB 14.0a7 I am seeing my driver crash. I suspect this is related to the NS version upgrade, as if I replace the .xpi archive in TB bundle with the NS 11.4.37 no crashes are observed. Also, if I use TB 14.0a6 with NS 11.4.40 the same crash behavior is observed. Note that using regular (non Selenium-driven) TB 14.0a7 is fine, hence I've not reported this to torproject's Alpha feedback.

I'd be happy to report this as a bug on the NoScript GitHub is you consider it appropriate. In any case I'll attempt to debug the issue myself.

Question: Do you publish a CHANGELOG for NS and/or nscl so I can review the changes made since 11.4.37 - I couldn't see one one in the GitHub repos?

Many thanks.
Mozilla/5.0 (Windows NT 10.0; rv:109.0) Gecko/20100101 Firefox/115.0
barbaz
Senior Member
Posts: 10921
Joined: Sat Aug 03, 2013 5:45 pm

Re: NoScript 11.4.40 crashed Tor Browser with Selenium

Post by barbaz »

*Always* check the changelogs BEFORE updating that important software!
Mozilla/5.0 (X11; Linux x86_64; rv:131.0) Gecko/20100101 Firefox/131.0
Brian Cohen
Posts: 3
Joined: Mon Sep 30, 2024 11:26 am

Re: NoScript 11.4.40 crashed Tor Browser with Selenium

Post by Brian Cohen »

Many thanks @barbaz, can you point me to the build instructions so I can build the intermediate versions & nail down exactly where the breaking change occurs? I tried to run the build.sh script from my cloned repo (after updating the `nscl` submodule) and got:

Code: Select all

./build.sh: line 136: web-ext: command not found
ERROR: Could not create /home/me/dev/noscript/xpi/noscript-11.4.39.xpi!
Mozilla/5.0 (Windows NT 10.0; rv:109.0) Gecko/20100101 Firefox/115.0
barbaz
Senior Member
Posts: 10921
Joined: Sat Aug 03, 2013 5:45 pm

Re: NoScript 11.4.40 crashed Tor Browser with Selenium

Post by barbaz »

I don't know a link with build instructions for NoScript (I have previously basically just zipped the whole repo and rename .zip to .xpi, which although it worked, is not a proper build - and along those lines, you might be able to run NoScript as a temporary extension). But regarding the error you posted, do you have the "web-ext" command-line tool installed?
*Always* check the changelogs BEFORE updating that important software!
Mozilla/5.0 (X11; Linux x86_64; rv:131.0) Gecko/20100101 Firefox/131.0
Brian Cohen
Posts: 3
Joined: Mon Sep 30, 2024 11:26 am

Re: NoScript 11.4.40 crashed Tor Browser with Selenium

Post by Brian Cohen »

do you have the "web-ext" command-line tool installed?
I do now (node install) and that did the trick, can build NoScript fine now. Thanks for your help.
Mozilla/5.0 (Windows NT 10.0; rv:109.0) Gecko/20100101 Firefox/115.0
Post Reply