[FIXED] 11.0.44rc cs order problem

Bug reports and enhancement requests
Post Reply
skriptimaahinen
Master Bug Buster
Posts: 244
Joined: Wed Jan 10, 2018 7:37 am

[FIXED] 11.0.44rc cs order problem

Post by skriptimaahinen »

A weird one that took too much of my time.

Sometimes (very rarely) the SyncFetchPolicy fails to run on the page (both FF 80 & 81). Could not figure a surefire way to reproduce, but here are the steps that might manifest it:

- Open any page.
- Reload and/or navigate to about:newtab and back. (Maybe necessary or not?)
- Wait for 5 minutes or more. (Important step!)
- Navigate to about:newtab and back.
- Observe SyncFetchPolicy failing to run.

If the above works once, it happens reliably after every 5+ min wait until the tab is closed. If not, closing and reloading tab/browser/NoScript might be what it takes. But it can be hard to get it into the right state. Whatever that might be. Also no idea where the ~5 min cutoff comes from. Simply determined by trial and error.

The clear underlaying reason for the SyncFetchPolicy failing to run is that the SyncFetchPolicy.js and DocumentFreezer.js are run after the other contentscripts.

The docs do state the contentscripts are run in the order they appear in the array, but there is no mentioning how multiple arrays are handled. So not sure if bug or not, but fallback is needed in case this might happen on other circumstances.
Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Firefox/78.0
User avatar
Giorgio Maone
Site Admin
Posts: 9454
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: 11.0.44rc cs order problem

Post by Giorgio Maone »

Should be fixed in latest development build, thanks.
v 11.0.44rc3
============================================================
x Fixed media placeholder not shown when blocking Youtube
movies
x Work around for unpredictable content script execution
order
x Ensure content of NoScript prompts is always visible
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:81.0) Gecko/20100101 Firefox/81.0
skriptimaahinen
Master Bug Buster
Posts: 244
Joined: Wed Jan 10, 2018 7:37 am

Re: 11.0.44rc cs order problem

Post by skriptimaahinen »

Typo in staticNS.js:49 - pendingFetchPolicy should be pendingSyncFetchPolicy, I assume.
Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Firefox/78.0
User avatar
Giorgio Maone
Site Admin
Posts: 9454
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: 11.0.44rc cs order problem

Post by Giorgio Maone »

Fixed in latest development build, thanks.
v 11.0.44rc4
============================================================
x Fixed namespacing issues with script replacements
x Fixed typo in content script ordering work-around
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:81.0) Gecko/20100101 Firefox/81.0
Post Reply