Bring back shift-click on script for NS10?

Ask for help about NoScript, no registration needed to post
kukla
Senior Member
Posts: 317
Joined: Mon May 04, 2009 12:08 am

Bring back shift-click on script for NS10?

Post by kukla »

Unaware if this has been discussed already, but any plans to bring back the shift-click feature to see what VirusTotal etc. report for a specific script? Or is this now available by way of something other than shift-click? Very useful feature. Would love to see it restored.
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:58.0) Gecko/20100101 Firefox/58.0
barbaz
Senior Member
Posts: 10847
Joined: Sat Aug 03, 2013 5:45 pm

Re: Bring back shift-click on script for NS10?

Post by barbaz »

It's available by middle-click on the site name, but last i checked the site it takes you to is hard-coded.
*Always* check the changelogs BEFORE updating that important software!
-
kukla
Senior Member
Posts: 317
Joined: Mon May 04, 2009 12:08 am

Re: Bring back shift-click on script for NS10?

Post by kukla »

barbaz wrote:It's available by middle-click on the site name, but last i checked the site it takes you to is hard-coded.
No middle click on Mac. But this is what I get with left click. After hitting OK, nothing happens.

Image
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:58.0) Gecko/20100101 Firefox/58.0
barbaz
Senior Member
Posts: 10847
Joined: Sat Aug 03, 2013 5:45 pm

Re: Bring back shift-click on script for NS10?

Post by barbaz »

Sorry, I got a bit mixed up. You're right, it's left-click, not middle-click.
kukla wrote: this is what I get with left click. After hitting OK, nothing happens.
I think this is a bug. Possibly related console messages -

(on clicking the site)

Code: Select all

Discarding onCreatedNavigationTarget for 95: received source tab data without any created tab data available
(on clicking OK)

Code: Select all

TypeError: can't access dead object[Learn More]  Storage.js:14:5
*Always* check the changelogs BEFORE updating that important software!
-
kukla
Senior Member
Posts: 317
Joined: Mon May 04, 2009 12:08 am

Re: Bring back shift-click on script for NS10?

Post by kukla »

Giorgio?
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:52.0) Gecko/20100101 Firefox/52.0
kukla
Senior Member
Posts: 317
Joined: Mon May 04, 2009 12:08 am

Re: Bring back shift-click on script for NS10?

Post by kukla »

Don't understand the silence. This is an almost indispensable feature (very tedious, next to impossible, to copy the urls of many scripts and then enter them, one by one, into VirusTotal.) I understand if it takes some time to investigate and hopefully fix. But please at least some response. Thanks.
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:58.0) Gecko/20100101 Firefox/58.0
User avatar
Giorgio Maone
Site Admin
Posts: 9454
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: Bring back shift-click on script for NS10?

Post by Giorgio Maone »

kukla wrote:Don't understand the silence. This is an almost indispensable feature (very tedious, next to impossible, to copy the urls of many scripts and then enter them, one by one, into VirusTotal.) I understand if it takes some time to investigate and hopefully fix. But please at least some response. Thanks.
I cannot reproduce the bug.

Firefox 58.0.2, clean profile. Installed NoScript, left clicked the first address listed either in the popup or in the Options page (tried both, in different profiles since your choice after the privacy warning prompt is remembered), and both times the noscript.net/about page has been correctly opened.

Might this be platform specific (barbaz, did you try on Mac OS X as well)?
I tried on Linux and Windows, BTW, no mac at hand ATM.
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
barbaz
Senior Member
Posts: 10847
Joined: Sat Aug 03, 2013 5:45 pm

Re: Bring back shift-click on script for NS10?

Post by barbaz »

Giorgio Maone wrote:(barbaz, did you try on Mac OS X as well)?
I don't have Mac OS for some years now. I use Xubuntu 16.04 64-bit.

The only possibly-relevant environment details I can think of are:
1) I use the Firefox 58.0.2 add-on-devel unbranded build
2) I always run Firefox in a firejail sandbox -

Code: Select all

firejail --overlay-tmpfs --noprofile firefox/firefox
STR:

1) https://noscript.net/getit, install NoScript Quantum latest dev build

2) open the NoScript popup

3) left-click "noscript.net"
*Always* check the changelogs BEFORE updating that important software!
-
User avatar
Giorgio Maone
Site Admin
Posts: 9454
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: Bring back shift-click on script for NS10?

Post by Giorgio Maone »

barbaz wrote:
Giorgio Maone wrote:(barbaz, did you try on Mac OS X as well)?
I don't have Mac OS for some years now. I use Xubuntu 16.04 64-bit.
Confirmed, it's platform-dependent (most likely window manager specific).
The problem happens only when you use this feature for the first time from the popup (instead of the Options tab), because on some (non-Windows) platforms the confirmation prompt causes the popup to be dismissed along with all its running code, therefore once you answer there's no code still alive to act on your input.
I'll probably have to fix it by temporarily opening the NoScript Options tab, handling the confirmation prompt from there, then closing it and either go back to the original tab or opening the information page, depending on user's answer.
Work around: just use this feature once from the Options page, giving NoScript permission to permanently enable it.
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
kukla
Senior Member
Posts: 317
Joined: Mon May 04, 2009 12:08 am

Re: Bring back shift-click on script for NS10?

Post by kukla »

Thanks Giorgio for the workaround, which works perfectly. Was concerned it wouldn't last through a restart (browser), but it does. Very good to have this feature working again.
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:58.0) Gecko/20100101 Firefox/58.0
Post Reply