[FIXED] NoScript 5.1.2 & Pale Moon 27.5.1

[pbcroc]

NoScript 5.1.2 doesn't work correctly with Pale Moon 27.5.1. Search bar doesn't work (can type some words in a text field, but can't press 'Enter' or click a 'search' button) and Pale Moon hangs after all.

[barbaz]

I see the same. But I don't see it until after restarting Pale Moon. Sometimes I get "The URL is not valid" instead of a freeze.

I will try to look into this.

[barbaz]

NoScript 5.1.1 works.
NoScript 5.1.2rc1 does not.

The following patch, applied to NoScript 5.1.2rc8, appears to fix the problem. But it kills the status bar icon for SeaMonkey, so is *not* suitable for inclusion.

Code: Select all

diff --git a/chrome/content/noscript/Restartless.jsm b/chrome/content/noscript/Restartless.jsm
--- a/chrome/content/noscript/Restartless.jsm
+++ b/chrome/content/noscript/Restartless.jsm
@@ -74,7 +74,7 @@
   INCLUDE("Main");
   Main.bootstrap();
 
-
+  createWidgetTemplate();
   Main.init();
   if (Main.webExt && addonData.webExtension) {
     Main.webExt.init(addonData.webExtension);
@@ -100,8 +100,9 @@
 var overlayURL  = NO_CACHE(`noscriptOverlay-noStatusBar.xul`);
 
 function createWidgetTemplate(window, callback) {
-  let xhr = new window.XMLHttpRequest();
-  if (window.document.getElementById("status-bar")) {
+  let xhr = window ? new window.XMLHttpRequest() : // Let's provide as much contextual info as possible, e.g. to Tor Browser
+              Cc["@mozilla.org/xmlextras/xmlhttprequest;1"].createInstance(Ci.nsIXMLHttpRequest);
+  if (window && window.document.getElementById("status-bar")) {
     overlayURL = overlayURL.replace("-noStatusBar", "");
   }
   xhr.open("GET", overlayURL);

I have no idea why this patch would have any effect on this issue, but it does.

[yes_noscript]

If i try to open a site from history in urlbar, the browser freeze if NoScript enabled.
If i enter a word in urlbar then normaly my default search engine open with that, but nothing hapens.

This wasnt the case in other versions
And the funny thing is: i dont use NoScript to control javascript- i only use the other features from NoScript. uMatrix control javascript

5.1.1 works fine

I can add or send a WhatIsHang and/ or appCrashView report if needed

[Giorgio Maone]

It seems to be a Palemoon-specific issue.
Could you please look into the browser console for any possibly related message (I suspect something about excessive recursion might pop up)?

[barbaz]

Threads merged.

[therube]

I can add or send a WhatIsHang

Can't hurt.
Just post it in a

Code: Select all

 block (if it fits), or link to from https://pastebin.com/ or similar.

[Giorgio Maone]

Just to understand: are these issues consistently reproducible?
I managed to make Palermoon 27.5.1 hang with NoScript 5.1.2 once (first try), but from then on I've been unable to reproduce (and unfortunately I realized that after a serie of false-positive "fixes" which actually did nothing, because the problem just wasn't manifesting itself)

[barbaz]

Just to understand: are these issues consistently reproducible?

I was able to reproduce this every time starting from a new profile, following these steps -
1) Install NoScript
2) File > Restart, restart Pale Moon
3) Try to type something in the URL bar and hit Enter

When I re-used the same profile, things got more erratic.

[yes_noscript]

It seems to be a Palemoon-specific issue.
Could you please look into the browser console for any possibly related message (I suspect something about excessive recursion might pop up)?

I cant because the browser freeze without any chance to do anything.

Here the windows logs:
https://pastebin.com/WKz8P3pv & https://pastebin.com/Vht6RDS8

Also see this Pale Moon forum thread: https://forum.palemoon.org/viewtopic.php?f=46&t=17022

[Giorgio Maone]

Please check latest development build 5.1.3rc1, thanks.

[yes_noscript]

The fix solve the problem. Good work!

But now with the NoScript update a new tab opens with https://www.purevpn.com/vpn-service/nos ... pecial.php
Why?

[therube]

the NoScript update a new tab opens with https://www.purevpn.com/vpn-service/nos ... pecial.php

(I didn't get that in SeaMonkey.)

[barbaz]

Please check latest development build 5.1.3rc1, thanks.

I confirm this is fixed. Thanks Giorgio!

But now with the NoScript update a new tab opens with https://www.purevpn.com/vpn-service/nos ... pecial.php
Why?

Not seeing that here. Are you somehow clicking a link in the NoScript release notes page?