noscript.key.revokeTemp shortcut not working.

[Mercury]

The noscript.key.revokeTemp keyboard shortcut does not work. It does, work, temporarily, immediately after being set, but this does not survive a browser restart.

Repro steps:

- Open about:config
- Set noscript.keys.tempAllowPage to VK_F8
- Set noscript.keys.revokeTemp to VK_F9
- (Optional) Navigate to a page with blocked scripts. Press F8. Press F9. Observe that both shortcuts work as intended.
- Completely close Firefox and restart.
- Navigate to a page with blocked scripts. Press F8. Observe this shortcut works as intended.
- Press F9. Observe that nothing happens.

Can anyone else confirm?

[barbaz]

Thanks for the report

I can confirm this in a clean Firefox 39.0 on Linux Mint 64-bit.
noscript.keys.revokeTemp must be set in the same session in which it's to be used. Doesn't seem to matter what keystroke you assign to it.

Nothing related in the Browser Console.

[Mercury]

Hello,

After a couple of updates, this bug is still not fixed (as of 2.6.9.38)

I understand if it's a low-priority issue, but is there an actual bug logged for this anywhere? Or, if not, any way for me to log a bug, other than in this forum?

[barbaz]

This forum is the place to report bugs, this thread is where it has been logged. Technically the place to report bugs is the NoScript Development forum, but that requires registration and in practice bugs often get reported in NoScript Support threads. Support vs Development can be a blurred line.
The best you can do is keep bumping this thread every few months or so (as you just did).
(If you do decide to register, we can move this thread to NoScript Development...)

[palme]

it seems the noscript.key.revokeTemp key doesn't work. it has to be set every startup of firefox manually to make it work again (go to about:confing and reassign a value), noscript.keys.tempAllowPage works as expected without setting it every startup.

would be nice to get this fixed. the bug was already reported here: viewtopic.php?f=7&t=21077

[palme]

i fixed the bug - "keys.revokeTemp" is not initialized therefore it doesn't work.

With this patch applied "keys.revokeTemp" works without setting it manually after every startup

Code: Select all

diff --git a/content/noscript/noscriptOverlay.js b/content/noscript/noscriptOverlay.js
index b047456..16325f1 100644
--- a/content/noscript/noscriptOverlay.js
+++ b/content/noscript/noscriptOverlay.js
@@ -2255,7 +2255,7 @@ return noscriptUtil.service ? {
       const initPrefs = [
         "statusIcon", "statusLabel", "preset",
         "keys.ui", "keys.toggle", "keys.tempAllowPage",
-        "notify", "notify.bottom",
+        "keys.revokeTemp", "notify", "notify.bottom",
         "notify.hide", "notify.hidePermanent", "notify.hideDelay",
         "stickyUI.liveReload",
         "hoverUI"

[barbaz]

Thank you for the patch. I will notify Giorgio that this is here.

[Giorgio Maone]

Thank you so much, it's gonna be in next release.

[therube]

(Heh. Funny, that come FF 44, or whatever, with signing, a user can't just go in & make the fix & be done.)

[palme]

Thank you so much, it's gonna be in next release.

You are welcome, thanks for the best addon ever

when will the next version be released?