Page 1 of 1

In Firefox 53 (Nigtly) Flashgot no longer works

Posted: Tue Nov 29, 2016 9:15 pm
by Romani
Just recently, after, i think, upgrading to Nightly 53 Flashgot just silently stopped to work. First sign i noticed is that FlashGot Media button no longer appears on sites with video, Youtube for example.
If i try to get About Flashgor window from Tools menu window never opens and i getting error in console
ReferenceError: gFlashGot is not defined[Learn More] browser.xul:1:1
onpopupshowing chrome://browser/content/browser.xul:1:1

I still can open Flashgot options windows from About:addons but its looks like all preferences is unset and there is tons of errors from any attempt to do anything in console, like

NS_ERROR_XPC_GS_RETURNED_FAILURE: Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService] flashgotCommon.js:22
<anonymous> chrome://flashgot/content/flashgotCommon.js:22:24
SyntaxError: missing ( after for flashgotOptions.js:224:6
ReferenceError: fgo_interceptionSelected is not defined[Learn More] flashgotOptions.xul:1:1
onselect chrome://flashgot/content/flashgotOptions.xul:1:1
set_selectedItem chrome://global/content/bindings/radio.xml:148:11
set_selectedIndex chrome://global/content/bindings/radio.xml:101:31
radiogroup_XBL_Constructor chrome://global/content/bindings/radio.xml:38:13
ReferenceError: fgo_onload is not defined[Learn More] flashgotOptions.xul:1:1
onload chrome://flashgot/content/flashgotOptions.xul:1:1

In short, Flashgot broken completely in Nightly. Using version v 1.5.6.13rc1 on 53.0a1 (2016-11-29) (Linux 64-bit)

Re: In Firefox 53 (Nigtly) Flashgot no longer works

Posted: Tue Nov 29, 2016 9:54 pm
by Romani
After some searching its looks that removal of for-each is to blame https://bugzilla.mozilla.org/show_bug.cgi?id=1293305

Re: In Firefox 53 (Nigtly) Flashgot no longer works

Posted: Wed Nov 30, 2016 6:52 am
by Giorgio Maone
Fixed in latest development build, thanks.

Re: In Firefox 53 (Nigtly) Flashgot no longer works

Posted: Fri Dec 02, 2016 3:16 pm
by DopefishJustin