Android Firefox Beta 36.0: Noscript Not Functioning

Android-specific support, bug reports and feature requests.
Post Reply
ca7g
Posts: 1
Joined: Mon Jan 19, 2015 3:42 pm

Android Firefox Beta 36.0: Noscript Not Functioning

Post by ca7g »

Just a heads up before this new Firefox rolls out in the general release: Noscript 3.5a7 doesn't seem to function at all on the new Firefox beta 36.0 as released on the Play store and using the new tablet interface. The Noscript selection doesn't even show up on the drop down menu. I hope this is an easy fix!
Mozilla/5.0 (Linux; Android 4.4.2; SM-P905V Build/KOT49H) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/39.0.2171.93 Safari/537.36
hempeter
Posts: 8
Joined: Fri May 23, 2014 12:03 am

Re: Android Firefox Beta 36.0: Noscript Not Functioning

Post by hempeter »

Been having a look at this since last week. Managed to narrow it down to exported objects not entering the global scope.

Fixed, as far as I can tell. I've issued a pull request to Lekensteyn, so hopefully this change can be merged into the main line.

For those interested, take a look:
Link
Last edited by Thrawn on Sun Feb 01, 2015 11:17 pm, edited 1 time in total.
Reason: Fix link to avoid truncation
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:35.0) Gecko/20100101 Firefox/35.0
Lekensteyn
Junior Member
Posts: 31
Joined: Thu May 19, 2011 12:01 pm

Re: Android Firefox Beta 36.0: Noscript Not Functioning

Post by Lekensteyn »

Thank you hempeter, confirmed that this is indeed an issue. Tested it with the XPI at https://lekensteyn.nl/files/noscript-ns ... nsteyn.xpi

source is at https://github.com/Lekensteyn/noscript- ... 7-20150202
Mozilla/5.0 (X11; Linux x86_64; rv:35.0) Gecko/20100101 Firefox/35.0
hempeter
Posts: 8
Joined: Fri May 23, 2014 12:03 am

Re: Android Firefox Beta 36.0: Noscript Not Functioning

Post by hempeter »

Glad to help :P
I did some playing last night, turned "Full Protection" on and some debug, I believe PageMod also needs a similar fix (just a 'this.PageMod = PageMod;' job).
I started a new thread on NoScript backporting. Feeling up for it @Lekensteyn? ;)
Glad that Mozilla's attempts to change things hasn't stopped this awesome addon yet =D

Peace, Pete
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:35.0) Gecko/20100101 Firefox/35.0
User avatar
Giorgio Maone
Site Admin
Posts: 9454
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: Android Firefox Beta 36.0: Noscript Not Functioning

Post by Giorgio Maone »

Merged in 3.5a8, thank you both.
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:35.0) Gecko/20100101 Firefox/35.0
Post Reply