Allowing sites by IP does not work

[Tallgeese]

If you attempt to whitelist a website that is referred to by static IP, the setting will be saved in the preferences (as shown in about:config), however it will not be honored. It doesn't appear poorly formed, so I do not know what could be happening here.

[Thrawn]

To be clear, does it show up in the NoScript menu using the IP address? Or does it show up using the domain name, and you simply chose to whitelist it using the IP address?

[therube]

What is the IP you have saved?

[Lekensteyn]

You forgot to tell us that you had a custom port.

Patch: https://github.com/Lekensteyn/noscript- ... it/df86a85

Code: Select all

--- a/src/noscript-nsa/modules/Policy.jsm
+++ b/src/noscript-nsa/modules/Policy.jsm
@@ -170,7 +170,10 @@ Policy.prototype = {
     if (!site) return "";
     
     const map = this.map;
-    
+
+    // Ignore port numbers
+    site = site.replace(/:\d+$/, "");
+
     // exact match
     if (site in map) return site;