Page 3 of 3

Re: Need feedback about my FlashGot-like addon

Posted: Tue Jun 16, 2020 4:56 pm
by pouriap19
therube wrote:
Mon Jun 15, 2020 11:29 am
DLG is unable to download from "firefox".
barbaz wrote:
Tue Jun 16, 2020 3:32 pm
So does it work if you set about:config > privacy.resistFingerprinting.block_mozAddonManager to true (you might need to create this boolean pref) and/or blank out about:config > extensions.webextensions.restrictedDomains ?
So I just checked Firefox Send and no it's not because of restricted domains. My bad for not properly looking into it at first.
It's actually what maxoku suggested. Because Send uses end-to-end encryption what is actually downloaded is an encrypted "blob" which then gets decrypted via JavaScript and then is served as a download. So it's not like a regular download that has a URL and an HTTP request. DLG detects downloads through interpreting requests.

I have looked into this issue briefly before because Mega also uses this format for downloading and it didn't seem possible because there's no request and no URL. The file is created inside JavaScript code and is lost the moment you click 'cancel' or 'ok'.
I'll look into it some more now that Firefox Send is also using this but I'm pretty sure it's impossible. It's actually "designed" to be impossible to intercept in order to make sure the end-to-end encryption is secure.

Re: Need feedback about my FlashGot-like addon

Posted: Mon Jun 29, 2020 8:27 am
by Lucas Rey
@pouriap19 Thank you for your great work, I'm searching a Flashgot replacement for IDM too (I'm currently using an old waterfox version who still supports flashgot).

Now I installed:
- Firefox Developer 78.0b9 (32-bit)
- download-grab-v0.11.0a.xpi
- Download.Grab.Native.Host.v0.11.0a.Setup.exe

But still get the IDM download window, I'm expecting https://imgur.com/a/sjCI0Vb as for flashgot. What's wrong? Am I missing some settings?

Thank you
Lucas

Re: Need feedback about my FlashGot-like addon

Posted: Mon Jun 29, 2020 10:38 am
by pouriap19
Lucas Rey wrote:
Mon Jun 29, 2020 8:27 am
@pouriap19 Thank you for your great work, I'm searching a Flashgot replacement for IDM too (I'm currently using an old waterfox version who still supports flashgot).

Now I installed:
- Firefox Developer 78.0b9 (32-bit)
- download-grab-v0.11.0a.xpi
- Download.Grab.Native.Host.v0.11.0a.Setup.exe

But still get the IDM download window, I'm expecting https://imgur.com/a/sjCI0Vb as for flashgot. What's wrong? Am I missing some settings?

Thank you
Lucas
Do you have browser integration enabled in IDM?
Close all your browsers then open IDM -> options -> General and then uncheck all browsers from the browsers list and then also uncheck the "Use advanced browser integration" option. Then click OK.

Re: Need feedback about my FlashGot-like addon

Posted: Mon Jun 29, 2020 1:00 pm
by therube
Default option (in the dropdown) to show only the video(s) attributable to the particular tab.
(With a "click" to display all.)

Show more information in the dropdown.
Size, at least, would be nice.
Maybe even the URL & or referrer.
(URL is visible on mouseover. Other information when you actually click an item, but less convenient.)

Ability to Copy the URL.
(Right-click would work nice for that. Heh ;-). Remember those days, when things were good.)

Ability to grab a NoScript blocked media item.
It seems that once NoScript blocks a media item, showing a placeholder, its' URL is known.
But DLG doesn't actually see anything, until the "block" is clicked, allowed, & the media actually starts to play.
The ability to Grab Link of the NoScript placeholder would be nice.


(I'll just note that first grab opens Net Transport [if not already opened] but does not grab. You then have to Grab a second time for it to register. For me [you've said otherwise], that behavior is different from FlashGot. FlashGot [Win7] always opened & grabbed.)

Re: Need feedback about my FlashGot-like addon

Posted: Mon Jun 29, 2020 2:26 pm
by Lucas Rey
pouriap19 wrote:
Mon Jun 29, 2020 10:38 am
Do you have browser integration enabled in IDM?
Close all your browsers then open IDM -> options -> General and then uncheck all browsers from the browsers list and then also uncheck the "Use advanced browser integration" option. Then click OK.
Thank you, but now I got the classic firefox download window
Image

However, with the right button I can choose the "Grab Link" Menu and the download starts with IDM. I would like to have however the window where I can choose the downloader as per your screenshot.

Re: Need feedback about my FlashGot-like addon

Posted: Mon Jun 29, 2020 5:48 pm
by pouriap19
Lucas Rey wrote:
Mon Jun 29, 2020 2:26 pm
Thank you, but now I got the classic firefox download window
Image

However, with the right button I can choose the "Grab Link" Menu and the download starts with IDM. I would like to have however the window where I can choose the downloader as per your screenshot.
Hmmm...
Have you checked Download Grab's options? "Override Firefox's download dialog" should be checked. Also make sure you haven't added .iso to the ignore list.
I'm using the same browser with the same addon version and it's working for me.

Re: Need feedback about my FlashGot-like addon

Posted: Mon Jun 29, 2020 6:29 pm
by pouriap19
therube wrote:
Mon Jun 29, 2020 1:00 pm
Default option (in the dropdown) to show only the video(s) attributable to the particular tab.
(With a "click" to display all.)
This will be implemented in the future.
Show more information in the dropdown.
I don't want the list to get too cluttered but I might add a little more info to the list or the hover info.
Ability to Copy the URL.
Will keep that in mind. Keyboard/mouse shortcuts will be added in the future.
Ability to grab a NoScript blocked media item.
I haven't looked into this as I don't use NoScript but I added it to my to-do list to check in the future.
I'll just note that first grab opens Net Transport [if not already opened] but does not grab. You then have to Grab a second time for it to register. For me [you've said otherwise], that behavior is different from FlashGot. FlashGot [Win7] always opened & grabbed.
I specifically checked Net Transport's underlying functions that handle downloads and they don't seem to have changed so DLG should work as FlashGot did. BTW I was using the trial version and the first time I grabbed (both with FlashGot and DLG) the purchase window would open. In order to test it I downloaded a pirated full version of Net Transport and now the downloads are grabbed with the first try.
Have you tried FlashGot and DLG on the same system? If on the same system FlashGot works and DLG doesn't I'll take another look.

Re: Need feedback about my FlashGot-like addon

Posted: Mon Jun 29, 2020 8:20 pm
by Lucas Rey
pouriap19 wrote:
Mon Jun 29, 2020 5:48 pm
Have you checked Download Grab's options? "Override Firefox's download dialog" should be checked. Also make sure you haven't added .iso to the ignore list.
I'm using the same browser with the same addon version and it's working for me.
Thank you, is working now!!!

Re: Need feedback about my FlashGot-like addon

Posted: Mon Jun 29, 2020 8:30 pm
by therube
Have you tried FlashGot and DLG on the same system? If on the same system FlashGot works and DLG doesn't I'll take another look.
Yes, Win7 x64 (& XP, for that matter).
SeaMonkey (for as long as I can remember) / FlashGot (for as long as I can remember).
FF Nightly & DLG.
(And I'm sure, over time, I must have also looked at FF [Legacy] & FlashGot, & certainly would have noted if it didn't work as expected.)
(Similarly, Pale Moon / FlashGot.)

Re: Need feedback about my FlashGot-like addon

Posted: Tue Jun 30, 2020 10:39 am
by pouriap19
therube wrote:
Mon Jun 29, 2020 8:30 pm
Yes, Win7 x64 (& XP, for that matter).
SeaMonkey (for as long as I can remember) / FlashGot (for as long as I can remember).
FF Nightly & DLG.
(And I'm sure, over time, I must have also looked at FF [Legacy] & FlashGot, & certainly would have noted if it didn't work as expected.)
(Similarly, Pale Moon / FlashGot.)
Can you give me your Net Transport version too? Also is it x64 or x86?

Re: Need feedback about my FlashGot-like addon

Posted: Tue Jun 30, 2020 3:30 pm
by therube
x86, 2.96L.725 (the most "recent")

Win7 x64. SeaMonkey x86, x64.
(FF, oh if 52, thinking it would have been x86? Probably x86 with FF 56 too?)



[Oh what do you know. 52 is x64 & 56 too.
52 definitely works (after, xpinstall.signatures.required;false).
Don't feel like figuring out the "fix" for 56, & as I have no signed versions of FlashGot...
What a bunch of crap, signing!]

Re: Need feedback about my FlashGot-like addon

Posted: Wed Jul 08, 2020 6:17 pm
by therube
(Don't know what this means, but maybe there is some relevance here?
Bug 1579911 Allow extensions to observe and modify requests created by downloads.download extension API)