Need feedback about my FlashGot-like addon

General discussion about web technology.
TAO
Posts: 1
Joined: Wed May 20, 2020 10:23 am

Re: Need feedback about my FlashGot-like addon

Post by TAO » Wed May 20, 2020 10:27 am

Really interesting, I've tried it and it's a good start but needs more work to be done.
I keep my eye on this project.
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:76.0) Gecko/20100101 Firefox/76.0

pouriap19
Posts: 10
Joined: Wed Apr 29, 2020 6:21 pm

New update

Post by pouriap19 » Tue May 26, 2020 10:45 am

Hey it's me.
I've made some improvements and attempted to fix the issues that maxoku had found:

Changes in v0.5.4a:
Major changes in download detection policies. Problems with falsely detecting downloads should be minimized now.
Fixed a problem with detecting download file names.
Added option to specify which file extensions should be grabbed.
Added option to specify which file extensions should be ignored.
Added option to specify which file extensions should be automatically sent to default DM.
Fixed a problem with the report button.

Known problems:
If a file's name is sent to the browser using the "Content-disposition" header and that name has UTF-8 characters in it then the name will be shown as gibberish. This is a browser problem and I can't do anything about it. But it's possible I'll be able to work around it with a hack.

Things that will be fixed in the future:
- When a text with no links is selected the 'Grab links' option still appears
- Add option for to grab image/video when right clicking on them
- FlashGot.exe will eventually be merged with the native host application, so there will be no need for node.exe and its scripts. Just FlashGot.exe
- Media will be sniffed in the page and grabbed. When media is grabbed a notification icon will appear in the address bar. Currently media that is explicitly loaded like <video> and <audio> are grabbed.
- Show number of grabbed items on toolbar button
- Option to show only grabbed items for the current page
- Files grabbed in private browsing will be only visible in private browsing windows and will be cleared when private browsing is over

Note:
If DLGrab tried to download something that it was not supposed to, for example a script that should be loaded into the page, then first kindly report it using the report button at the bottom of the download dialog, then choose "Continue with -> Browser" which will cause this file to be loaded as normal without the intervention of DLGrab.

Download/Update link is available in my original post.

maxoku wrote:
Sat May 16, 2020 9:16 pm
Or instead to change anything it could utilize (if possible) other add-ons that grab them to use Download Grab instead of the browser.
It's possible. But the authors of those addons have to add this functionality to their addons.
What other add-ons are you rewriting? I might be interested in them as well.
Currently none. TabmixPlus is not possible to recreate with the current API. But some of its features might be. I might give it a try in the future but currently I'm occupied with Download Grab.
It seems that it can't override the dialog window in one case. When mp4 videos are suppose to be opened and played in the browser.
This is a feature. Some people might want to view these files in the browser instead of downloading them. I've added an option for this now that you can disable if you want.
For some reason it also can't do it with txt files it seems.
Same as above. Plain text files, PDF files and media files are by default opened in browser. If you want to be prompted for download use the option mentioned above.

(Sorry for the long wait. I've been trying to install Visual Studio for the past week and I'm still unsuccessful. Piece of garbage. :x )
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:73.0) Gecko/20100101 Firefox/73.0

User avatar
maxoku
Posts: 13
Joined: Tue Sep 17, 2019 6:12 pm
Location: Poland

Re: Need feedback about my FlashGot-like addon

Post by maxoku » Tue May 26, 2020 4:02 pm

Great, seems everything you mentioned works properly now. Thanks 👍
I'll be waiting for more improvements to test them anytime.
Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0

User avatar
therube
Ambassador
Posts: 7584
Joined: Thu Mar 19, 2009 4:17 pm
Location: Maryland USA

Re: Need feedback about my FlashGot-like addon

Post by therube » Sun May 31, 2020 12:02 pm

So node.exe (node.js, & DLGrabspawner.exe) persist in the FF process space.

There have been odd times, on opening FF, that I'd get a "message" (yeah, don't ask what it said), & I'd have to restart FF to get DLG back working.


It works. It's nice. It allows using my download manager. It's better then anything native from FF.
But... it's not enough, because there is no "detection".
So unless there is a link you can select, or a download dialog request it can hook in to...


Now, don't get me wrong, when I say, "not enough", it is not enough to drag FF from the scourge (isn't that what trump calls it) that it is, to anything remotely like, FF. IOW, am I going to switch from SeaMonkey, & NoScript & FlashGot (& everything else that "just works") to FF any time soon? LOL.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.19) Gecko/20110420 SeaMonkey/2.0.14 Pinball NoScript FlashGot AdblockPlus
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0 SeaMonkey/2.53.4

User avatar
therube
Ambassador
Posts: 7584
Joined: Thu Mar 19, 2009 4:17 pm
Location: Maryland USA

Re: Need feedback about my FlashGot-like addon

Post by therube » Sun May 31, 2020 12:04 pm

Maybe if DLG had a 'Paste from clipboard' (&/or 'Grab from clipboard')... that would be a benefit.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.19) Gecko/20110420 SeaMonkey/2.0.14 Pinball NoScript FlashGot AdblockPlus
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0 SeaMonkey/2.53.4

User avatar
therube
Ambassador
Posts: 7584
Joined: Thu Mar 19, 2009 4:17 pm
Location: Maryland USA

Re: Need feedback about my FlashGot-like addon

Post by therube » Sun May 31, 2020 4:46 pm

Oh, I'm running this setup, sandboxed, Sandboxie.

SBIE2205 Service not implemented: ConsoleInit (C00000D4)
a node.exe "console" window opened (empty, black)

Download Grab
ERROR: ERROR: No download managers found on the system

(A browser restart should "fix" this.)
Yes, but maybe ? with a DLG disable/enable toggling too.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.19) Gecko/20110420 SeaMonkey/2.0.14 Pinball NoScript FlashGot AdblockPlus
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0 SeaMonkey/2.53.4

User avatar
therube
Ambassador
Posts: 7584
Joined: Thu Mar 19, 2009 4:17 pm
Location: Maryland USA

Re: Need feedback about my FlashGot-like addon

Post by therube » Tue Jun 02, 2020 2:47 am

i don't know if this is related to DLG, but...

running FF sandboxed, Sandboxie
i've been keeping FF open, running, in the sandbox
i update (Nightly) FF (outside the sandbox) - even though the instance running sandboxed has not been restarted
the sandboxed instance (source if you will) stems from the non-sandboxed FF
(iow, FF is extracted, outside the sandbox, & from there, "firefox.exe" is run, sandboxed - so the sandboxed "version" is the unsandboxed "version", only told to run, sandboxed [heh, did that confuse you ;-)])

anyhow, been running like this for a while now...
computer goes to sleep, whenever, wakes up & i continue on...

yesterday (or day before ?), existing instance of FF, i go to open a link in a new window
window opens, but not the link
type a url in, hit return & nothing, Ctrl+W to close the window, nothing
the close 'X' box does close the window
attempt to open in new tab, no dice

FF is fubar'd

Quit
restart & carry on...

get to today, same situation, FF not working as expected

don't know if this is quirk in FF, FF/Sandboxie, FF/Sandboxie & updates, DLG/node.exe...

so, just throwing this out there...

(& the only reason i happen to be purposely keeping FF open, is because i was on one of those "never ending" pages, & while i can restore the page, it doesn't restore it's position - in the never ending, so all i can do is to try to find where i had left off... which since this has now occurred, twice, i'm going to have to do anyhow. will find another site to peruse - that is not never ending...)
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.19) Gecko/20110420 SeaMonkey/2.0.14 Pinball NoScript FlashGot AdblockPlus
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0 SeaMonkey/2.53.4

User avatar
therube
Ambassador
Posts: 7584
Joined: Thu Mar 19, 2009 4:17 pm
Location: Maryland USA

Re: Need feedback about my FlashGot-like addon

Post by therube » Tue Jun 02, 2020 3:05 am

What do you mean by "detection"?
Only that FlashGot & yes, I know this isn't FG, in addition to "feeding" links to a download manager, could also "detect" links (i.e., FlashGot Media), which this doesn't do at all (which I understand). But as I look at it, FG did both. With this, & more pointing out that while this does some, the other part, detection, there would be another tool needed to accomplish that.
not enough
Well, I can certainly judge "not enough" - for me :-).
Even NoScript - until it was able to work with bookmarklets (which it could not do, early on), was not enough - for me.
(And I did not use it - until it did work with bookmarklets.)

Paste from(/Grab from) clipboard, with the thought that if I have to use another utility to "detect" a link, if that other utility can copy the link to the clipboard, & if DLG can grab that link (clipboard copy), then in that vein DLG has "detected" the link (so then able to be passed to download manager).


Now, don't get me wrong, this works, & it is a help.


But from my perspective (& I'll broaden scope), Quantum is limited in what it does (which is the real problem).
And extensions, & users, & developers have to live with - worse. Worse then they had.
To me, that just doesn't make sense :roll:.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.19) Gecko/20110420 SeaMonkey/2.0.14 Pinball NoScript FlashGot AdblockPlus
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0 SeaMonkey/2.53.4

User avatar
maxoku
Posts: 13
Joined: Tue Sep 17, 2019 6:12 pm
Location: Poland

Re: Need feedback about my FlashGot-like addon

Post by maxoku » Tue Jun 02, 2020 5:17 pm

therube wrote:
Tue Jun 02, 2020 3:05 am
in addition to "feeding" links to a download manager, could also "detect" links (i.e., FlashGot Media), which this doesn't do at all
It has a toolbar button that grabs many files to its list. Also medias, maybe not all of them, but still. As I use it now it detects all mp4 video files that suppose to. It's still alpha, so it's not perfect and fully comfortable to use. Generally I use Video Downloader Prime add-on that grabs links and I right click them to grab it with DLG. It still has its issues, but it's better than nothing. What add-ons do you use for media grabbing?
Well, I can certainly judge "not enough" - for me
Still don't know what you need besides the media.
Paste from(/Grab from) clipboard, with the thought that if I have to use another utility to "detect" a link, if that other utility can copy the link to the clipboard, & if DLG can grab that link (clipboard copy), then in that vein DLG has "detected" the link (so then able to be passed to download manager).
Doesn't your download manager have such function to grab links from clipboard? Does FlashGot has it?

BTW update your DLG, it's in version 0.6.2a now. It's much better than before.
Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0

pouriap19
Posts: 10
Joined: Wed Apr 29, 2020 6:21 pm

Re: Need feedback about my FlashGot-like addon

Post by pouriap19 » Tue Jun 02, 2020 7:32 pm

@therube
The problems you're facing seems to be from node running in the background. Apparently your sandbox doesn't like console windows (that's what Googling that error code suggested), and node is console window.
Currently the addon's ability to detect file downloads seems to be alright. The next step is to update flashgot.exe to work with recent versions of download managers. It already works with a lot of them but I want to add new download managers and update/remove the ones that do not work anymore.
I've contacted Giorgio about some help with building flashgot.exe, and hopefully we'll have a brand new flashgot.exe not long from now. This more might or might not help with your issues.
After that I'll go back to the addon and add the ability to grab media.
Media grabbing will be added to DLG. And it will be good. I promise. :geek:
After that I'll go back to the native host and get rid of node.js for good. Everything will be standalone executables eventually.
This is the general roadmap I have in mind for this project.

Also I'm going to be away for a couple days so there won't be any updates from me in that time.

Cheers.
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:73.0) Gecko/20100101 Firefox/73.0

Post Reply